{"id":13730,"url":"https://patchwork.libcamera.org/api/1.1/patches/13730/?format=json","web_url":"https://patchwork.libcamera.org/patch/13730/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210907154650.11507-1-laurent.pinchart@ideasonboard.com>","date":"2021-09-07T15:46:50","name":"[libcamera-devel,v3.1,26/30] qcam: Print bytesused for all planes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"656f97031746f8c6584f0704798f67999bd67ccc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13730/mbox/","series":[{"id":2491,"url":"https://patchwork.libcamera.org/api/1.1/series/2491/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2491","date":"2021-09-07T15:44:41","name":null,"version":1,"mbox":"https://patchwork.libcamera.org/series/2491/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13730/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13730/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5503BE175\n\tfor ;\n\tTue, 7 Sep 2021 15:47:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AB1F6916C;\n\tTue, 7 Sep 2021 17:47:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E69060251\n\tfor ;\n\tTue, 7 Sep 2021 17:47:12 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4665224F\n\tfor ;\n\tTue, 7 Sep 2021 17:47:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"huqKIkoi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631029632;\n\tbh=AUuLfCYRU01TSxzU8FZREzpvFLvu8rxBgqn5SoJxuPA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=huqKIkoi8Gi+LYN32hbstWnPkcrgBXY70hLt6TqWeHeSCNFWJpA6OVZDwoRHQA8AL\n\t7u8BrWur4qvkBfqxf6NliBUyrU1CN0XW6yIxSI3gzlhxDd81hZX6MZ0CKwE83s7w5P\n\tZH76NtPGH+UgN4UcDsJojaSS9b+NDjelCwaxmdK0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 7 Sep 2021 18:46:50 +0300","Message-Id":"<20210907154650.11507-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210906225636.14683-26-laurent.pinchart@ideasonboard.com>","References":"<20210906225636.14683-26-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3.1 26/30] qcam: Print bytesused for all\n\tplanes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fix the debug message that prints frame metadata to print the number of\nbytes used for each plane, not just the first one.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \n---\nChanges since v3:\n\n- Separate bytesused for planes with comma instead of slash\n---\n src/qcam/main_window.cpp | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex ac853e360aea..129aeb0b6b2e 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -20,6 +20,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -754,10 +755,14 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n \tfps = lastBufferTime_ && fps ? 1000000000.0 / fps : 0.0;\n \tlastBufferTime_ = metadata.timestamp;\n \n+\tQStringList bytesused;\n+\tfor (const FrameMetadata::Plane &plane : metadata.planes())\n+\t\tbytesused << QString::number(plane.bytesused);\n+\n \tqDebug().noquote()\n \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n-\t\t<< \"bytesused:\" << metadata.planes()[0].bytesused\n-\t\t<< \"timestamp:\" << metadata.timestamp\n+\t\t<< \"bytesused: {\" << bytesused.join(\", \")\n+\t\t<< \"} timestamp:\" << metadata.timestamp\n \t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps;\n \n \t/* Render the frame on the viewfinder. */\n","prefixes":["libcamera-devel","v3.1","26/30"]}