{"id":13714,"url":"https://patchwork.libcamera.org/api/1.1/patches/13714/?format=json","web_url":"https://patchwork.libcamera.org/patch/13714/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210907111038.739104-3-jacopo@jmondi.org>","date":"2021-09-07T11:10:35","name":"[libcamera-devel,v2,2/5] ipa: proxy_worker: Reset ControlSerializer on worker","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f22c3ea95beaa2f3ff321d663be23ce843d518cd","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13714/mbox/","series":[{"id":2487,"url":"https://patchwork.libcamera.org/api/1.1/series/2487/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2487","date":"2021-09-07T11:10:33","name":"libcamera: control serializer fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/2487/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13714/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13714/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12DA5BE175\n\tfor ;\n\tTue, 7 Sep 2021 11:10:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D389869174;\n\tTue, 7 Sep 2021 13:09:59 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D67060252\n\tfor ;\n\tTue, 7 Sep 2021 13:09:57 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 3721D60009;\n\tTue, 7 Sep 2021 11:09:56 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 7 Sep 2021 13:10:35 +0200","Message-Id":"<20210907111038.739104-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210907111038.739104-1-jacopo@jmondi.org>","References":"<20210907111038.739104-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/5] ipa: proxy_worker: Reset\n\tControlSerializer on worker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When running the IPA in isolated mode, each side of the IPC boundary\nhas an instance of the ControlSerializer class which is used to\nserializer/deserialize controls before transmitting them on the wire.\n\nThe IPAProxyWorker, which creates and manages the process the IPA runs in,\ndoes not reset its ControlSerializer upon an IPA::configure() call, while\nthe IPAProxy does, effectively creating a misalignment between the\ntwo sides of the fence.\n\nThis obviously creates issues as one side of the IPC runs with a\npopulated and possibly stale cache of ControlInfoMap references, while the\nother side gets reset every time a new configuration is applied to the\nCamera.\n\nFix that by resetting the IPAProxyWorker ControlSerializer on an\nIPA configure() call.\n\nThis change fixes an issue which is easily triggered by running two\nconsecutive capture sessions with the IPA running in isolated mode:\nERROR Serializer control_serializer.cpp:520 Can't deserialize ControlList: unknown ControlInfoMap\n\nFixes: 7832e19a599e (\"utils: ipc: add templates for code generation for IPC mechanism\")\nSigned-off-by: Jacopo Mondi \nReviewed-by: Umang Jain \nReviewed-by: Paul Elder \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n .../libcamera_templates/module_ipa_proxy_worker.cpp.tmpl | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl\nindex c54ecdb90a1a..c5e51532db53 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl\n@@ -79,6 +79,10 @@ public:\n \n {% for method in interface_main.methods %}\n \t\tcase {{cmd_enum_name}}::{{method.mojom_name|cap}}: {\n+\n+{%- if method.mojom_name == \"configure\" %}\n+\t\t\tcontrolSerializer_.reset();\n+{%- endif %}\n \t\t{{proxy_funcs.deserialize_call(method|method_param_inputs, '_ipcMessage.data()', '_ipcMessage.fds()', false, true)|indent(8, true)}}\n {% for param in method|method_param_outputs %}\n \t\t\t{{param|name}} {{param.mojom_name}};\n","prefixes":["libcamera-devel","v2","2/5"]}