{"id":13692,"url":"https://patchwork.libcamera.org/api/1.1/patches/13692/?format=json","web_url":"https://patchwork.libcamera.org/patch/13692/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210906225636.14683-26-laurent.pinchart@ideasonboard.com>","date":"2021-09-06T22:56:32","name":"[libcamera-devel,v3,26/30] qcam: Print bytesused for all planes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"be65f41f8218c94c5b2763f53cb905c480b86053","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13692/mbox/","series":[{"id":2482,"url":"https://patchwork.libcamera.org/api/1.1/series/2482/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2482","date":"2021-09-06T22:54:20","name":"libcamera: Handle fallout of FrameBuffer offset support","version":3,"mbox":"https://patchwork.libcamera.org/series/2482/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13692/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13692/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DC58BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  6 Sep 2021 22:57:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9D5169189;\n\tTue,  7 Sep 2021 00:57:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CCB269178\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  7 Sep 2021 00:57:09 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5D22993;\n\tTue,  7 Sep 2021 00:57:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W26jC5AG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630969029;\n\tbh=cSKnrdogwcNGPHLRhmFzlEpzq2IKVZJt43uev+8QhGU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W26jC5AGmwDwcmcZKpen2mc3QpwW+EQa55GZEhyTbrlBXLFY2l9e55NofNDV4A6U0\n\tty9BCID3kqP2Pyhqxd2caDc7FBozKIZVssOHKYkCS6xu9g+EHE3mKmrpBixomLf2t5\n\tej6ortP265QaAe92epjDGpioegARTes8V7H5l2do=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue,  7 Sep 2021 01:56:32 +0300","Message-Id":"<20210906225636.14683-26-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>","References":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 26/30] qcam: Print bytesused for all\n\tplanes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Fix the debug message that prints frame metadata to print the number of\nbytes used for each plane, not just the first one.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex ac853e360aea..0a00b1001570 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -20,6 +20,7 @@\n #include <QInputDialog>\n #include <QMutexLocker>\n #include <QStandardPaths>\n+#include <QStringList>\n #include <QTimer>\n #include <QToolBar>\n #include <QToolButton>\n@@ -754,9 +755,13 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n \tfps = lastBufferTime_ && fps ? 1000000000.0 / fps : 0.0;\n \tlastBufferTime_ = metadata.timestamp;\n \n+\tQStringList bytesused;\n+\tfor (const FrameMetadata::Plane &plane : metadata.planes())\n+\t\tbytesused << QString::number(plane.bytesused);\n+\n \tqDebug().noquote()\n \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n-\t\t<< \"bytesused:\" << metadata.planes()[0].bytesused\n+\t\t<< \"bytesused:\" << bytesused.join(\"/\")\n \t\t<< \"timestamp:\" << metadata.timestamp\n \t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps;\n \n","prefixes":["libcamera-devel","v3","26/30"]}