{"id":13668,"url":"https://patchwork.libcamera.org/api/1.1/patches/13668/?format=json","web_url":"https://patchwork.libcamera.org/patch/13668/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210906225636.14683-2-laurent.pinchart@ideasonboard.com>","date":"2021-09-06T22:56:08","name":"[libcamera-devel,v3,02/30] libcamera: file_descriptor: Add a function to retrieve the inode","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d6de49eb7ea01f92d2b5b2bcbc703d1d919e23f9","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13668/mbox/","series":[{"id":2482,"url":"https://patchwork.libcamera.org/api/1.1/series/2482/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2482","date":"2021-09-06T22:54:20","name":"libcamera: Handle fallout of FrameBuffer offset support","version":3,"mbox":"https://patchwork.libcamera.org/series/2482/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13668/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13668/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A34EBE175\n\tfor ;\n\tMon, 6 Sep 2021 22:57:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 842CB69174;\n\tTue, 7 Sep 2021 00:57:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A23769167\n\tfor ;\n\tTue, 7 Sep 2021 00:56:59 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEA60993;\n\tTue, 7 Sep 2021 00:56:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"evgzIiaW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630969019;\n\tbh=uLkB9Y9I1Q8pO5WttL2JG13L9GNHJ16SgH6o+Osv5LE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=evgzIiaWssesMIWVcdrDz1b5LFnoWuf/w6l5g7QX/RLas70oMQI1SrX8LSSM2Q9v/\n\tsGmFK6FW1iy/1wF4J21MwhViWxxfljj4GUEapBD1WxD9ehjsLfBjIEguwH4qBxcSN7\n\tCqCEbARZHDG9GWpdwulFAG4kBf/Hc0JMKdioTPSA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 7 Sep 2021 01:56:08 +0300","Message-Id":"<20210906225636.14683-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>","References":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 02/30] libcamera: file_descriptor: Add\n\ta function to retrieve the inode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The inode is useful to check if two file descriptors refer to the same\nfile. Add a function to retrieve it.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nReviewed-by: Jean-Michel Hautbois \nReviewed-by: Paul Elder \nReviewed-by: Hirokazu Honda \n---\nChanges since v1:\n\n- Use isValid() instead of open-coding it\n- Print a message on error\n---\n include/libcamera/file_descriptor.h | 3 +++\n src/libcamera/file_descriptor.cpp | 26 ++++++++++++++++++++++++++\n 2 files changed, 29 insertions(+)","diff":"diff --git a/include/libcamera/file_descriptor.h b/include/libcamera/file_descriptor.h\nindex d514aac7697b..988f9b7a3d25 100644\n--- a/include/libcamera/file_descriptor.h\n+++ b/include/libcamera/file_descriptor.h\n@@ -8,6 +8,7 @@\n #define __LIBCAMERA_FILE_DESCRIPTOR_H__\n \n #include \n+#include \n \n namespace libcamera {\n \n@@ -27,6 +28,8 @@ public:\n \tint fd() const { return fd_ ? fd_->fd() : -1; }\n \tFileDescriptor dup() const;\n \n+\tino_t inode() const;\n+\n private:\n \tclass Descriptor\n \t{\ndiff --git a/src/libcamera/file_descriptor.cpp b/src/libcamera/file_descriptor.cpp\nindex 9f9ebc81f738..0409c3e1758c 100644\n--- a/src/libcamera/file_descriptor.cpp\n+++ b/src/libcamera/file_descriptor.cpp\n@@ -8,6 +8,8 @@\n #include \n \n #include \n+#include \n+#include \n #include \n #include \n \n@@ -221,6 +223,30 @@ FileDescriptor FileDescriptor::dup() const\n \treturn FileDescriptor(fd());\n }\n \n+/**\n+ * \\brief Retrieve the file descriptor inode\n+ *\n+ * \\todo Should this move to the File class ?\n+ *\n+ * \\return The file descriptor inode on success, or 0 on error\n+ */\n+ino_t FileDescriptor::inode() const\n+{\n+\tif (!isValid())\n+\t\treturn 0;\n+\n+\tstruct stat st;\n+\tint ret = fstat(fd_->fd(), &st);\n+\tif (ret < 0) {\n+\t\tret = -errno;\n+\t\tLOG(FileDescriptor, Fatal)\n+\t\t\t<< \"Failed to fstat() fd: \" << strerror(-ret);\n+\t\treturn 0;\n+\t}\n+\n+\treturn st.st_ino;\n+}\n+\n FileDescriptor::Descriptor::Descriptor(int fd, bool duplicate)\n {\n \tif (!duplicate) {\n","prefixes":["libcamera-devel","v3","02/30"]}