{"id":1366,"url":"https://patchwork.libcamera.org/api/1.1/patches/1366/?format=json","web_url":"https://patchwork.libcamera.org/patch/1366/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190605221817.966-6-paul.elder@ideasonboard.com>","date":"2019-06-05T22:18:12","name":"[libcamera-devel,RFC,05/10] libcamera: ipa_module_info: add field for isolation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"517416778df2177fc6603e7a5ff896e1f8d71f46","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1366/mbox/","series":[{"id":339,"url":"https://patchwork.libcamera.org/api/1.1/series/339/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=339","date":"2019-06-05T22:18:07","name":"Add IPA process isolation","version":1,"mbox":"https://patchwork.libcamera.org/series/339/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1366/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1366/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CE2B63B83\n\tfor ;\n\tThu, 6 Jun 2019 00:18:32 +0200 (CEST)","from localhost.localdomain (unknown [96.44.9.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77BC7566;\n\tThu, 6 Jun 2019 00:18:31 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559773111;\n\tbh=4T0kdIeH0qOe7OtK4s+I90fvGoIWqoGB4QAeW8UnRWw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ukjEm1cO+p6TtZoKsT2y/E2kZYA1zhCmzs2fCIUx461naqI8U0Ie2GgGO4fSd14ZN\n\tcoskJKBb3+o2iGtvIASIPyCtJ1Bszb2AfllV7QHRzkWpnckD+5yxmdQ0++MUukATWy\n\tqQk1rpCalWYE0SlTs2S7psOYvxKMPvrNRN7NqYrw=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 5 Jun 2019 18:18:12 -0400","Message-Id":"<20190605221817.966-6-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190605221817.966-1-paul.elder@ideasonboard.com>","References":"<20190605221817.966-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 05/10] libcamera: ipa_module_info: add\n\tfield for isolation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 05 Jun 2019 22:18:32 -0000"},"content":"Add a field to IPAModuleInfo that determines whether or not the IPA\nmodule needs to be isolated in a separated process.\n\nAlso increment the IPA_MODULE_API_VERSION, due to the change to struct\nIPAModuleInfo. Update the dummy IPA and IPA test to conform to the new\nstruct layout.\n\nSigned-off-by: Paul Elder \n---\n include/libcamera/ipa/ipa_module_info.h | 3 ++-\n src/ipa/ipa_dummy.cpp | 1 +\n test/ipa/ipa_test.cpp | 1 +\n 3 files changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h\nindex 585f753..cb112e4 100644\n--- a/include/libcamera/ipa/ipa_module_info.h\n+++ b/include/libcamera/ipa/ipa_module_info.h\n@@ -9,7 +9,7 @@\n \n #include \n \n-#define IPA_MODULE_API_VERSION 1\n+#define IPA_MODULE_API_VERSION 2\n \n namespace libcamera {\n \n@@ -18,6 +18,7 @@ struct IPAModuleInfo {\n \tuint32_t pipelineVersion;\n \tchar pipelineName[256];\n \tchar name[256];\n+\tint isolate;\n } __attribute__((packed));\n \n extern \"C\" {\ndiff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\nindex ee7a3a8..a8ff88c 100644\n--- a/src/ipa/ipa_dummy.cpp\n+++ b/src/ipa/ipa_dummy.cpp\n@@ -34,6 +34,7 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \t0,\n \t\"PipelineHandlerVimc\",\n \t\"Dummy IPA for Vimc\",\n+\t0,\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\nindex bbef069..2682bae 100644\n--- a/test/ipa/ipa_test.cpp\n+++ b/test/ipa/ipa_test.cpp\n@@ -59,6 +59,7 @@ protected:\n \t\t\t0,\n \t\t\t\"PipelineHandlerVimc\",\n \t\t\t\"Dummy IPA for Vimc\",\n+\t\t\t0,\n \t\t};\n \n \t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n","prefixes":["libcamera-devel","RFC","05/10"]}