{"id":13601,"url":"https://patchwork.libcamera.org/api/1.1/patches/13601/?format=json","web_url":"https://patchwork.libcamera.org/patch/13601/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210902064416.6342-1-martin.kepplinger@puri.sm>","date":"2021-09-02T06:44:16","name":"[libcamera-devel] libcamera: add hi846 camera sensor properties","commit_ref":"06e53199c2563105030bda4c72752b853da7edc8","pull_url":null,"state":"accepted","archived":false,"hash":"0bdba5d299b49cf3e735348fb85452c068a7d6bd","submitter":{"id":93,"url":"https://patchwork.libcamera.org/api/1.1/people/93/?format=json","name":"Martin Kepplinger","email":"martin.kepplinger@puri.sm"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13601/mbox/","series":[{"id":2436,"url":"https://patchwork.libcamera.org/api/1.1/series/2436/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2436","date":"2021-09-02T06:44:16","name":"[libcamera-devel] libcamera: add hi846 camera sensor properties","version":1,"mbox":"https://patchwork.libcamera.org/series/2436/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13601/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13601/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADD2ABDC71\n\tfor ;\n\tThu, 2 Sep 2021 06:45:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42B636916A;\n\tThu, 2 Sep 2021 08:45:11 +0200 (CEST)","from comms.puri.sm (comms.puri.sm [159.203.221.185])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9509360503\n\tfor ;\n\tThu, 2 Sep 2021 08:45:09 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n\tby comms.puri.sm (Postfix) with ESMTP id 60AC7E0165;\n\tWed, 1 Sep 2021 23:44:37 -0700 (PDT)","from comms.puri.sm ([127.0.0.1])\n\tby localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id a_7BjaSdi6SM; Wed, 1 Sep 2021 23:44:32 -0700 (PDT)"],"From":"Martin Kepplinger ","To":"laurent.pinchart@ideasonboard.com,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 2 Sep 2021 08:44:16 +0200","Message-Id":"<20210902064416.6342-1-martin.kepplinger@puri.sm>","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: add hi846 camera sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Martin Kepplinger ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add camera sensor properties for the Hynix hi846 sensor.\nThe part is also called YACG4D0C9SHC and a datasheet can be found at\nhttps://product.skhynix.com/products/cis/cis.go\n\nThis is the selfie camera in the Librem 5 phone.\n\nSigned-off-by: Martin Kepplinger \n---\n\nNote that the driver is not yet merged into the mainline but being\nreviewed:\nhttps://lore.kernel.org/linux-media/20210831134344.1673318-1-martin.kepplinger@puri.sm/\nlibcamera doesn't warn about anything when using the camera. `cam` streams\nand qcam shows a (non-debayered) image.\n\nthanks,\n martin\n\n\n src/libcamera/camera_sensor_properties.cpp | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)","diff":"diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex 4ee45e72..39bb282d 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -52,6 +52,24 @@ LOG_DEFINE_CATEGORY(CameraSensorProperties)\n const CameraSensorProperties *CameraSensorProperties::get(const std::string &sensor)\n {\n \tstatic const std::map sensorProps = {\n+\t\t{ \"hi846\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n+\t\t\t\t{ 1, controls::draft::TestPatternModeSolidColor },\n+\t\t\t\t{ 2, controls::draft::TestPatternModeColorBars },\n+\t\t\t\t{ 3, controls::draft::TestPatternModeColorBarsFadeToGray },\n+\t\t\t\t{ 4, controls::draft::TestPatternModePn9 },\n+\t\t\t\t/*\n+\t\t\t\t * No corresponding test pattern mode for:\n+\t\t\t\t * 5: \"Gradient Horizontal\"\n+\t\t\t\t * 6: \"Gradient Vertical\"\n+\t\t\t\t * 7: \"Check Board\"\n+\t\t\t\t * 8: \"Slant Pattern\"\n+\t\t\t\t * 9: \"Resolution Pattern\"\n+\t\t\t\t */\n+\t\t\t},\n+\t\t} },\n \t\t{ \"imx219\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n","prefixes":["libcamera-devel"]}