{"id":1358,"url":"https://patchwork.libcamera.org/api/1.1/patches/1358/?format=json","web_url":"https://patchwork.libcamera.org/patch/1358/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190605005316.4835-11-paul.elder@ideasonboard.com>","date":"2019-06-05T00:53:16","name":"[libcamera-devel,v3,10/10] libcamera: pipeline: vimc: add dummy IPA","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3624315e34610ec291e0b49c57398bb51953da6f","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1358/mbox/","series":[{"id":336,"url":"https://patchwork.libcamera.org/api/1.1/series/336/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=336","date":"2019-06-05T00:53:06","name":"Add IPAManager and IPAInterface","version":3,"mbox":"https://patchwork.libcamera.org/series/336/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1358/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1358/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 327E964720\n\tfor ;\n\tWed, 5 Jun 2019 02:53:35 +0200 (CEST)","from localhost.localdomain (unknown [96.44.9.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CB1C9BC;\n\tWed, 5 Jun 2019 02:53:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559696015;\n\tbh=gK0u0l3VetDjQuopNDzrP+AtpRMLmuagyrlF/GCxfA4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=V8XHYSlD7WoaQbUYElpDlijm2w4qLT5hpbkanNrcYxmd3RMZz4z0WugYM0yDZypGQ\n\tjgRQjDzu4uJZi4UtlRiFbx/BJFNzcojZXHlOfpcxbtthseUcsHSgFORd14QJQH2J6c\n\tgil8NAe++n/17dzxseGTd+H+Q6/4cMns9ktSCrEc=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 4 Jun 2019 20:53:16 -0400","Message-Id":"<20190605005316.4835-11-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190605005316.4835-1-paul.elder@ideasonboard.com>","References":"<20190605005316.4835-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 10/10] libcamera: pipeline: vimc: add\n\tdummy IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 05 Jun 2019 00:53:35 -0000"},"content":"Make the vimc pipeline handler get the dummy IPA, to show how an IPA can\nbe acquired by a pipeline handler.\n\nSigned-off-by: Paul Elder \n---\nChanges in v3:\n- save IPA to VIMC pipeline data\n- no IPA is non-fatal warning\n\nChanges in v2:\n- save IPA to pipeline data\n- no IPA is fatal error\n\n src/libcamera/pipeline/vimc.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 0e4eede..ad4577a 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -9,10 +9,13 @@\n #include \n \n #include \n+#include \n+#include \n #include \n #include \n \n #include \"device_enumerator.h\"\n+#include \"ipa_manager.h\"\n #include \"log.h\"\n #include \"media_device.h\"\n #include \"pipeline_handler.h\"\n@@ -77,6 +80,8 @@ private:\n \t\treturn static_cast(\n \t\t\tPipelineHandler::cameraData(camera));\n \t}\n+\n+\tstd::unique_ptr ipa_;\n };\n \n VimcCameraConfiguration::VimcCameraConfiguration()\n@@ -248,6 +253,12 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \tif (!media)\n \t\treturn false;\n \n+\tipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n+\tif (ipa_ == nullptr)\n+\t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n+\telse\n+\t\tipa_->init();\n+\n \tstd::unique_ptr data = utils::make_unique(this);\n \n \t/* Locate and open the capture video node. */\n","prefixes":["libcamera-devel","v3","10/10"]}