{"id":1357,"url":"https://patchwork.libcamera.org/api/1.1/patches/1357/?format=json","web_url":"https://patchwork.libcamera.org/patch/1357/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190605005316.4835-10-paul.elder@ideasonboard.com>","date":"2019-06-05T00:53:15","name":"[libcamera-devel,v3,09/10] libcamera: test: remove test IPA and use dummy IPA instead","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"711a586d93a56d3735c51a51792574a223bd5c33","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1357/mbox/","series":[{"id":336,"url":"https://patchwork.libcamera.org/api/1.1/series/336/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=336","date":"2019-06-05T00:53:06","name":"Add IPAManager and IPAInterface","version":3,"mbox":"https://patchwork.libcamera.org/series/336/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1357/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1357/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 997AC64720\n\tfor ;\n\tWed, 5 Jun 2019 02:53:34 +0200 (CEST)","from localhost.localdomain (unknown [96.44.9.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDFEA2D1;\n\tWed, 5 Jun 2019 02:53:33 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559696014;\n\tbh=t2wkwpSghKHJ8pPXWQvy3esnWgO0patx4uwB6AJY3Ms=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UWUlYnVj3J6segd38cb8Kln0tnu65y2EbaBbXocp8GwiC0ckebXeDq/cEQomXzrab\n\tZPOe3SjaOkj3iSvGioqxnLnMzL9Fg4eUGzlP0fzOOus2g0498fwdU6HzyKJrYC51jH\n\tM83a6SZbIrJjNz4S2ZXkjGE05TjDj6zY/mgX/JTg=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 4 Jun 2019 20:53:15 -0400","Message-Id":"<20190605005316.4835-10-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190605005316.4835-1-paul.elder@ideasonboard.com>","References":"<20190605005316.4835-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 09/10] libcamera: test: remove test IPA\n\tand use dummy IPA instead","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 05 Jun 2019 00:53:34 -0000"},"content":"Use the dummy IPA for testing/sample IPA instead of the earlier test\nIPA. Remove the test IPA, and update tests and meson accordingly.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n---\nChanges in v3:\n- delete the unused test IPA shared object source\n\nChanges in v2:\n- use macros for defining the fields in the expected IPA module info\n\n test/ipa/ipa_test.cpp | 8 ++++----\n test/ipa/meson.build | 10 ----------\n test/ipa/shared_test.cpp | 14 --------------\n 3 files changed, 4 insertions(+), 28 deletions(-)\n delete mode 100644 test/ipa/shared_test.cpp","diff":"diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\nindex 63e4243..bbef069 100644\n--- a/test/ipa/ipa_test.cpp\n+++ b/test/ipa/ipa_test.cpp\n@@ -56,12 +56,12 @@ protected:\n \n \t\tconst struct IPAModuleInfo testInfo = {\n \t\t\tIPA_MODULE_API_VERSION,\n-\t\t\t9001,\n-\t\t\t\"bleep\",\n-\t\t\t\"It's over nine thousand!\",\n+\t\t\t0,\n+\t\t\t\"PipelineHandlerVimc\",\n+\t\t\t\"Dummy IPA for Vimc\",\n \t\t};\n \n-\t\tcount += runTest(\"test/ipa/ipa-dummy-cpp.so\", testInfo);\n+\t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n \n \t\tif (count < 0)\n \t\t\treturn TestFail;\ndiff --git a/test/ipa/meson.build b/test/ipa/meson.build\nindex 08ee95c..bca39fa 100644\n--- a/test/ipa/meson.build\n+++ b/test/ipa/meson.build\n@@ -1,13 +1,3 @@\n-ipa_modules_sources = [\n- ['ipa-dummy-cpp', 'shared_test.cpp'],\n-]\n-\n-foreach m : ipa_modules_sources\n- shared_library(m, name_prefix : '',\n- dependencies : libcamera_dep,\n- include_directories : test_includes_public)\n-endforeach\n-\n ipa_test = [\n ['ipa_test', 'ipa_test.cpp'],\n ]\ndiff --git a/test/ipa/shared_test.cpp b/test/ipa/shared_test.cpp\ndeleted file mode 100644\nindex 8bac439..0000000\n--- a/test/ipa/shared_test.cpp\n+++ /dev/null\n@@ -1,14 +0,0 @@\n-#include \n-\n-namespace libcamera {\n-\n-extern \"C\" {\n-const struct libcamera::IPAModuleInfo ipaModuleInfo = {\n-\tIPA_MODULE_API_VERSION,\n-\t9001,\n-\t\"bleep\",\n-\t\"It's over nine thousand!\",\n-};\n-};\n-\n-}; /* namespace libcamera */\n","prefixes":["libcamera-devel","v3","09/10"]}