{"id":13516,"url":"https://patchwork.libcamera.org/api/1.1/patches/13516/?format=json","web_url":"https://patchwork.libcamera.org/patch/13516/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210826213016.1829504-2-umang.jain@ideasonboard.com>","date":"2021-08-26T21:30:12","name":"[libcamera-devel,RFC,1/5] android: post_processor: Inherit from libcamera::Object","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d6756eab1e2c1a628bf4740307fe4c71e71e41e2","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13516/mbox/","series":[{"id":2401,"url":"https://patchwork.libcamera.org/api/1.1/series/2401/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2401","date":"2021-08-26T21:30:11","name":"android: Async post-processing","version":1,"mbox":"https://patchwork.libcamera.org/series/2401/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13516/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13516/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4167FC3241\n\tfor ;\n\tThu, 26 Aug 2021 21:30:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2AEA68928;\n\tThu, 26 Aug 2021 23:30:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EA1D68939\n\tfor ;\n\tThu, 26 Aug 2021 23:30:28 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.246])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E304191F;\n\tThu, 26 Aug 2021 23:30:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GuWIhXOp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630013428;\n\tbh=gJ+LbJJ+dxzljpBCnlUKcnMNM/xGWD/NL5UWZu7Y4bo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GuWIhXOp6KevLY7ygSc3JEfVmxhuYjP/1YeKvI0grfcHAKLlRVPUTNi/DbbFEWRI/\n\tKKw1mMBpJQnCNa2xpnbabekRZz/g5oLYBLK86pKdYwKMVLOdim/Fud6CH53GiuT/Z/\n\tmKLbj3OsOwIMmTOWY/5OtE4zJhpwixHOP4OGc4V4=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 27 Aug 2021 03:00:12 +0530","Message-Id":"<20210826213016.1829504-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210826213016.1829504-1-umang.jain@ideasonboard.com>","References":"<20210826213016.1829504-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 1/5] android: post_processor: Inherit\n\tfrom libcamera::Object","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Currently, the post processing of a stream happens synchronously in\nCameraStream::process(). There is a plan to offload this processing to\na separate worker thread. In order to achieve that, we need to move\nthe post processor to a separate thread and invoke methods on it from\nthe CameraStream's thread. Object::moveToThread() and\nObject::invokeMethod() shall be used respectively, to achieve that\ngoal. Hence, inherit the PostProcessor interface from libcamera::object.\n\nSigned-off-by: Umang Jain \n---\n src/android/post_processor.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/post_processor.h b/src/android/post_processor.h\nindex ab2b2c60..b2b5bd55 100644\n--- a/src/android/post_processor.h\n+++ b/src/android/post_processor.h\n@@ -7,6 +7,8 @@\n #ifndef __ANDROID_POST_PROCESSOR_H__\n #define __ANDROID_POST_PROCESSOR_H__\n \n+#include \n+\n #include \n #include \n \n@@ -14,7 +16,7 @@\n \n class CameraMetadata;\n \n-class PostProcessor\n+class PostProcessor : public libcamera::Object\n {\n public:\n \tvirtual ~PostProcessor() = default;\n","prefixes":["libcamera-devel","RFC","1/5"]}