{"id":13487,"url":"https://patchwork.libcamera.org/api/1.1/patches/13487/?format=json","web_url":"https://patchwork.libcamera.org/patch/13487/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210825102937.3740405-5-kieran.bingham@ideasonboard.com>","date":"2021-08-25T10:29:36","name":"[libcamera-devel,4/5] Documentation: application-developer: Fix reference to cam BufferWriter","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fd49b3edcd32c073d85b0df4af5a4b5fa00724c4","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13487/mbox/","series":[{"id":2392,"url":"https://patchwork.libcamera.org/api/1.1/series/2392/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2392","date":"2021-08-25T10:29:32","name":"application-developer: Clean up","version":1,"mbox":"https://patchwork.libcamera.org/series/2392/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13487/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13487/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CB7EBD87D\n\tfor ;\n\tWed, 25 Aug 2021 10:29:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4D1E688E4;\n\tWed, 25 Aug 2021 12:29:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4FE160504\n\tfor ;\n\tWed, 25 Aug 2021 12:29:42 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EBB024F;\n\tWed, 25 Aug 2021 12:29:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tu0VRdyO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629887382;\n\tbh=DXDjloYdW+OI6qoiD2w/P7rtA84Ry682Oj9x9Kctvew=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tu0VRdyOthyCgrMzNYhkIlPMvDUhhyHTMks7clwrbDMoi9h9SacfZ1vN+OmdbaAgv\n\tb+Yy289uIHso0CNMVGfPjtvGADd7WjWeSxro+qhSTRF9FbGIOujO2g5gZZ5qg3fCZy\n\tmo0i+n1fO4r30MxSYZJRZuN3CMN0vS19s8nIN8Yw=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 25 Aug 2021 11:29:36 +0100","Message-Id":"<20210825102937.3740405-5-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210825102937.3740405-1-kieran.bingham@ideasonboard.com>","References":"<20210825102937.3740405-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/5] Documentation: application-developer:\n\tFix reference to cam BufferWriter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The BufferWriter class has been replaced by the FileSink.\n\nAdapt the reference, to match the source code.\n\nSigned-off-by: Kieran Bingham \n---\n Documentation/guides/application-developer.rst | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\nindex e2ed79d5173e..5f43af9e5a7a 100644\n--- a/Documentation/guides/application-developer.rst\n+++ b/Documentation/guides/application-developer.rst\n@@ -466,10 +466,10 @@ and the bytes used by planes.\n A completed buffer contains of course image data which can be accessed through\n the per-plane dma-buf file descriptor transported by the ``FrameBuffer``\n instance. An example of how to write image data to disk is available in the\n-`BufferWriter class`_ which is a part of the ``cam`` utility application in the\n+`FileSink class`_ which is a part of the ``cam`` utility application in the\n libcamera repository.\n \n-.. _BufferWriter class: https://git.linuxtv.org/libcamera.git/tree/src/cam/buffer_writer.cpp\n+.. _FileSink class: https://git.linuxtv.org/libcamera.git/tree/src/cam/file_sink.cpp\n \n With the handling of this request completed, it is possible to re-use the\n buffers by adding them to a new ``Request`` instance with their matching\n","prefixes":["libcamera-devel","4/5"]}