{"id":1347,"url":"https://patchwork.libcamera.org/api/1.1/patches/1347/?format=json","web_url":"https://patchwork.libcamera.org/patch/1347/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190603231637.28554-11-paul.elder@ideasonboard.com>","date":"2019-06-03T23:16:37","name":"[libcamera-devel,v2,10/10] libcamera: pipeline: vimc: add dummy IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"68c6d525ee11be245e93e300032e9fecc3d601f6","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1347/mbox/","series":[{"id":335,"url":"https://patchwork.libcamera.org/api/1.1/series/335/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=335","date":"2019-06-03T23:16:27","name":"Add IPAManager and IPAInterface","version":2,"mbox":"https://patchwork.libcamera.org/series/335/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1347/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1347/checks/","tags":{},"headers":{"Return-Path":"<paul.elder@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2459D618F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Jun 2019 01:16:54 +0200 (CEST)","from localhost.localdomain (unknown [96.44.9.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E0B151C;\n\tTue,  4 Jun 2019 01:16:53 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559603813;\n\tbh=K2tLOK1usFqbAdnG9qt0ZB+0ooznf3NDvsqvkNsOp54=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lvSLTNiYrzRcajUeHUAeBeiDUGQc4tckHPgtM1vy2h+Rgh/ggC2tNtOt/M/CB2akW\n\tFH/tdSKAR0ryXtP81nq5a7FiHlJC627iEM9wLmKIGu1rj94wDIBAx3Cy85U/ZZaAq9\n\t7Z4zBpgKtWGOGhdKxTFxls0SZlzIcw1AlhSu0Gkg=","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon,  3 Jun 2019 19:16:37 -0400","Message-Id":"<20190603231637.28554-11-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190603231637.28554-1-paul.elder@ideasonboard.com>","References":"<20190603231637.28554-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 10/10] libcamera: pipeline: vimc: add\n\tdummy IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 03 Jun 2019 23:16:54 -0000"},"content":"Make the vimc pipeline handler get the dummy IPA, to show how an IPA can\nbe acquired by a pipeline handler.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\nChanges in v2:\n- save IPA to pipeline data\n- no IPA is fatal error\n\n src/libcamera/pipeline/vimc.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 78feeb8..f000c21 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -10,10 +10,12 @@\n \n #include <libcamera/camera.h>\n #include <libcamera/ipa/ipa_module_info.h>\n+#include <libcamera/ipa/ipa_interface.h>\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n \n #include \"device_enumerator.h\"\n+#include \"ipa_manager.h\"\n #include \"log.h\"\n #include \"media_device.h\"\n #include \"pipeline_handler.h\"\n@@ -252,6 +254,15 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \tif (!media)\n \t\treturn false;\n \n+\tIPAManager *ipaManager = IPAManager::instance();\n+\tipa_ = ipaManager->createIPA(this);\n+\tif (ipa_ == nullptr) {\n+\t\tLOG(VIMC, Error) << \"no matching IPA found\";\n+\t\treturn false;\n+\t} else {\n+\t\tipa_->init();\n+\t}\n+\n \tstd::unique_ptr<VimcCameraData> data = utils::make_unique<VimcCameraData>(this);\n \n \t/* Locate and open the capture video node. */\n","prefixes":["libcamera-devel","v2","10/10"]}