{"id":13368,"url":"https://patchwork.libcamera.org/api/1.1/patches/13368/?format=json","web_url":"https://patchwork.libcamera.org/patch/13368/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210816043138.957984-11-hiroh@chromium.org>","date":"2021-08-16T04:31:38","name":"[libcamera-devel,RFC,10/10] libcamera: framebuffer: Add assertion to detect offset is unfilled","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6b80c00338f7b42ab76422b2322aa7255880e451","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13368/mbox/","series":[{"id":2359,"url":"https://patchwork.libcamera.org/api/1.1/series/2359/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2359","date":"2021-08-16T04:31:28","name":"Add offset to FrameBuffer::Plane","version":1,"mbox":"https://patchwork.libcamera.org/series/2359/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13368/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13368/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14AEDBD87D\n\tfor ;\n\tMon, 16 Aug 2021 04:32:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA984688A2;\n\tMon, 16 Aug 2021 06:32:05 +0200 (CEST)","from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com\n\t[IPv6:2607:f8b0:4864:20::102d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBCCD68894\n\tfor ;\n\tMon, 16 Aug 2021 06:32:03 +0200 (CEST)","by mail-pj1-x102d.google.com with SMTP id\n\tu13-20020a17090abb0db0290177e1d9b3f7so30424397pjr.1\n\tfor ;\n\tSun, 15 Aug 2021 21:32:03 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:6f5f:1479:a6ab:4229])\n\tby smtp.gmail.com with ESMTPSA id\n\tu10sm2767417pgj.48.2021.08.15.21.32.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 15 Aug 2021 21:32:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"n+En1NwB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=T0dHkJ+PNUMoZsj2N4CcOXDLrqClbhhh/k1FY/GiBJ4=;\n\tb=n+En1NwBdcH4TcPaMwrSbLNjbPZ7eHu5aquTG1xyL87Alq2AyAfq6VIKenL2dRFAQi\n\tfujSyt1idViZxifcccws3ejuPsn2x8NiGOTiSjgsg7FWVfyQt10kwHyPXLFuKOI+MZn8\n\t6DLyqH6WK1qyinAXMxm6v0s1y/cp0XizzKuGE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=T0dHkJ+PNUMoZsj2N4CcOXDLrqClbhhh/k1FY/GiBJ4=;\n\tb=tic79EACsHlOI7QsD4WX6LzWU5e7eAWs3a/gmFr/tJavZ9cOF9g3Py1QEvQLUQmZmQ\n\toC/s+jbMiY/C1ocPQxC72u1E3bFpKq0adlE7fNUbK587+5m2y9wguPKZo3cjN6Lgeq+w\n\tYuXa9tFmslT8V4nvc+HONmU8BlrbSkbSrQBLFxfj/DOAPGwHhb8zYkuFVyPp5xl0a2kn\n\t8TchJdFkrjyztQP8YX2+DUz45LxVkcR6++q/h3ZQII054s5xdeaaOU4CxWLnseUzb2Zt\n\tgMWY7X/BE+5D7oprIhHwjziLaqqbwogk3QVm0R1V6qiuZUF/qS5EgE4L7/QKsVgBiDJK\n\tAaAg==","X-Gm-Message-State":"AOAM533Wpuq8BcSzJ7FshRjzQ+l/t06u7PRWkLlBS7up/BHiHJnZMm1h\n\tC5XgMCEHvaMI2N9lCt0ilqtDVIMC1Lyr/Q==","X-Google-Smtp-Source":"ABdhPJyIbuE9t6aeZQu06o+X2h+vnUq44B/CC7xAWI3oOnHCX7F7G9PmG5tUl2yjnW288PcM/xOXCg==","X-Received":"by 2002:aa7:8e4e:0:b029:3e0:28db:d73b with SMTP id\n\td14-20020aa78e4e0000b02903e028dbd73bmr14309318pfr.8.1629088322111; \n\tSun, 15 Aug 2021 21:32:02 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 16 Aug 2021 13:31:38 +0900","Message-Id":"<20210816043138.957984-11-hiroh@chromium.org>","X-Mailer":"git-send-email 2.33.0.rc1.237.g0d66db33f3-goog","In-Reply-To":"<20210816043138.957984-1-hiroh@chromium.org>","References":"<20210816043138.957984-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 10/10] libcamera: framebuffer: Add\n\tassertion to detect offset is unfilled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The offset variable is introduced to FrameBuffer::Plane. In order to\ndetect that the plane is used while the offset is not set, this adds\nthe assertion to FrameBuffer::planes(). It should be removed in the\nfuture.\n\nSigned-off-by: Hirokazu Honda \n---\n include/libcamera/framebuffer.h | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 5de3c744..79541557 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -7,6 +7,8 @@\n #ifndef __LIBCAMERA_FRAMEBUFFER_H__\n #define __LIBCAMERA_FRAMEBUFFER_H__\n \n+#include \n+#include \n #include \n #include \n \n@@ -41,14 +43,21 @@ class FrameBuffer final : public Extensible\n \n public:\n \tstruct Plane {\n+\t\tstatic constexpr unsigned int kInvalidOffset = std::numeric_limits::max();\n \t\tFileDescriptor fd;\n-\t\tunsigned int offset;\n+\t\tunsigned int offset = kInvalidOffset;\n \t\tunsigned int length;\n \t};\n \n \tFrameBuffer(const std::vector &planes, unsigned int cookie = 0);\n \n-\tconst std::vector &planes() const { return planes_; }\n+\tconst std::vector &planes() const\n+\t{\n+\t\t/* \\todo remove this assert. */\n+\t\tfor (const auto &plane : planes_)\n+\t\t\tassert(plane.offset != Plane::kInvalidOffset);\n+\t\treturn planes_;\n+\t}\n \n \tRequest *request() const;\n \tconst FrameMetadata &metadata() const { return metadata_; }\n","prefixes":["libcamera-devel","RFC","10/10"]}