{"id":13324,"url":"https://patchwork.libcamera.org/api/1.1/patches/13324/?format=json","web_url":"https://patchwork.libcamera.org/patch/13324/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210812042249.1073932-1-paul.elder@ideasonboard.com>","date":"2021-08-12T04:22:49","name":"[libcamera-devel,v2] ipa: raspberrypi: Use boolean constructor for AeEnable ControlInfo","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0eae8f795c6764ac36c5778fe6507407bdf3ea0d","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13324/mbox/","series":[{"id":2343,"url":"https://patchwork.libcamera.org/api/1.1/series/2343/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2343","date":"2021-08-12T04:22:49","name":"[libcamera-devel,v2] ipa: raspberrypi: Use boolean constructor for AeEnable ControlInfo","version":2,"mbox":"https://patchwork.libcamera.org/series/2343/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13324/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13324/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 443DDBD87D\n\tfor ;\n\tThu, 12 Aug 2021 04:23:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6CF86884D;\n\tThu, 12 Aug 2021 06:23:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86B9760260\n\tfor ;\n\tThu, 12 Aug 2021 06:22:59 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 079B2EE;\n\tThu, 12 Aug 2021 06:22:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"STknoXGT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628742179;\n\tbh=Nr5yDMDDpW7dYJqhVlwfYjcvUZLyG5P4I9EFYEUj2as=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=STknoXGT58VRfVWEWUx85qSQvlBbGw2YNrWfag+YQIWFOOIwifHvy9LOr6diK7WGI\n\tR5ffwT4qUDHUuJVVWayZQDbyeYEGvmXZ8Thc6t0byKUvZaO1Qc056xTEYbUtBhNoGf\n\tlTE+WSxrKO4Grvw5xL/BwE2B3Irt23czc5iy2wDA=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 12 Aug 2021 13:22:49 +0900","Message-Id":"<20210812042249.1073932-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] ipa: raspberrypi: Use boolean\n\tconstructor for AeEnable ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The min-max constructor is not the proper constructor for boolean\nControlInfos. Use the proper boolean constructor.\n\nSigned-off-by: Paul Elder \n\n---\nChanges in v2:\n- whoops, sorry v1 was based on Jacopo's \"libcamera: Initialize controls\n in the IPA\"\n---\n include/libcamera/ipa/raspberrypi.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex a8790000..7ef14e57 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -28,7 +28,7 @@ namespace RPi {\n * unsupported control is encountered.\n */\n static const ControlInfoMap Controls = {\n-\t{ &controls::AeEnable, ControlInfo(false, true) },\n+\t{ &controls::AeEnable, ControlInfo({false, true}, true) },\n \t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n \t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n \t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },\n","prefixes":["libcamera-devel","v2"]}