{"id":13291,"url":"https://patchwork.libcamera.org/api/1.1/patches/13291/?format=json","web_url":"https://patchwork.libcamera.org/patch/13291/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210810161134.2243796-2-kieran.bingham@ideasonboard.com>","date":"2021-08-10T16:11:32","name":"[libcamera-devel,1/3] libcamera: controls: Use a const ControlValidator","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2c83bb018a0af097dc8e4fdd3765533a3e5472cd","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13291/mbox/","series":[{"id":2335,"url":"https://patchwork.libcamera.org/api/1.1/series/2335/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2335","date":"2021-08-10T16:11:31","name":"Request: Use the Camera's CameraControlValidator","version":1,"mbox":"https://patchwork.libcamera.org/series/2335/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13291/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13291/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C6E5C3240\n\tfor ;\n\tTue, 10 Aug 2021 16:11:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25C296884F;\n\tTue, 10 Aug 2021 18:11:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A64E68822\n\tfor ;\n\tTue, 10 Aug 2021 18:11:37 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEC5D4A3;\n\tTue, 10 Aug 2021 18:11:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fRrccUhT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628611897;\n\tbh=pzdpimxjBSbOq/vVvZim7cHr4+lv4OH0LEiPERJ4PaQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fRrccUhTu6vSqKr94xKimv7mAT/PPIlYs28/wbjNvAGBf+ixmwCNAgN9V9sv2Xnhf\n\tnD5o8AzrFZvw/rSEDG6rkB1BLatHC6EU1oasIt8TclE+a87qZZ2jBuuMUgVg6RyYhS\n\t6WlEbTJXPRo2cKsIeExtba4S+62SwKwXC2roC4Mw=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 10 Aug 2021 17:11:32 +0100","Message-Id":"<20210810161134.2243796-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210810161134.2243796-1-kieran.bingham@ideasonboard.com>","References":"<20210810161134.2243796-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/3] libcamera: controls: Use a const\n\tControlValidator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ControlValidator passed to a ControlList constructor\nis used, but not modified.\n\nMake it const.\n\nSigned-off-by: Kieran Bingham \n---\n include/libcamera/controls.h | 6 +++---\n src/libcamera/controls.cpp | 6 ++++--\n 2 files changed, 7 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex de733bd868a6..2c38b23ad443 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -354,8 +354,8 @@ private:\n \n public:\n \tControlList();\n-\tControlList(const ControlIdMap &idmap, ControlValidator *validator = nullptr);\n-\tControlList(const ControlInfoMap &infoMap, ControlValidator *validator = nullptr);\n+\tControlList(const ControlIdMap &idmap, const ControlValidator *validator = nullptr);\n+\tControlList(const ControlInfoMap &infoMap, const ControlValidator *validator = nullptr);\n \n \tusing iterator = ControlListMap::iterator;\n \tusing const_iterator = ControlListMap::const_iterator;\n@@ -413,7 +413,7 @@ private:\n \tconst ControlValue *find(unsigned int id) const;\n \tControlValue *find(unsigned int id);\n \n-\tControlValidator *validator_;\n+\tconst ControlValidator *validator_;\n \tconst ControlIdMap *idmap_;\n \tconst ControlInfoMap *infoMap_;\n \ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 64fd5c296226..a5943700ea89 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -836,7 +836,8 @@ ControlList::ControlList()\n * controls is provided by controls::controls and can be used as the \\a idmap\n * argument.\n */\n-ControlList::ControlList(const ControlIdMap &idmap, ControlValidator *validator)\n+ControlList::ControlList(const ControlIdMap &idmap,\n+\t\t\t const ControlValidator *validator)\n \t: validator_(validator), idmap_(&idmap), infoMap_(nullptr)\n {\n }\n@@ -846,7 +847,8 @@ ControlList::ControlList(const ControlIdMap &idmap, ControlValidator *validator)\n * \\param[in] infoMap The ControlInfoMap for the control list target object\n * \\param[in] validator The validator (may be null)\n */\n-ControlList::ControlList(const ControlInfoMap &infoMap, ControlValidator *validator)\n+ControlList::ControlList(const ControlInfoMap &infoMap,\n+\t\t\t const ControlValidator *validator)\n \t: validator_(validator), idmap_(&infoMap.idmap()), infoMap_(&infoMap)\n {\n }\n","prefixes":["libcamera-devel","1/3"]}