{"id":13241,"url":"https://patchwork.libcamera.org/api/1.1/patches/13241/?format=json","web_url":"https://patchwork.libcamera.org/patch/13241/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210805222436.6263-11-laurent.pinchart@ideasonboard.com>","date":"2021-08-05T22:24:36","name":"[libcamera-devel,10/10] libcamera: pipeline: simple: Remove SimplePipelineHandler::activeCamera_","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a52fadb39f63675caa5ce54fc1a22309777f6660","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13241/mbox/","series":[{"id":2314,"url":"https://patchwork.libcamera.org/api/1.1/series/2314/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2314","date":"2021-08-05T22:24:26","name":"Concurrent camera support in simple pipeline handler","version":1,"mbox":"https://patchwork.libcamera.org/series/2314/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13241/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13241/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C58EC323F\n\tfor ;\n\tThu, 5 Aug 2021 22:25:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE65E688C4;\n\tFri, 6 Aug 2021 00:25:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 161776026E\n\tfor ;\n\tFri, 6 Aug 2021 00:24:59 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7B8EE1A\n\tfor ;\n\tFri, 6 Aug 2021 00:24:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BbRA8H/9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628202298;\n\tbh=onBRKaLyfm/6CNuVZw+yrSXTsWxSPIsGaRDjGdCdkdE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=BbRA8H/9fqBC4OIzrkFqrpiV0oJb7oBegCRrV22tCReBBJyDMqOlXK5pJvJJS3HXf\n\tkkMulstepF7dVnOH0I5ldE1pjJ62XDBbsQsM6kT/+8TOD5TPTC9Bpz/txsDXI5382n\n\tNBVX9jVdNhXG5HPNl6SWMe0lW5y+bJTFxyfxufY4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Aug 2021 01:24:36 +0300","Message-Id":"<20210805222436.6263-11-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210805222436.6263-1-laurent.pinchart@ideasonboard.com>","References":"<20210805222436.6263-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 10/10] libcamera: pipeline: simple: Remove\n\tSimplePipelineHandler::activeCamera_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The SimplePipelineHandler activeCamera_ member pointer is set but never\nused. Drop it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/simple/simple.cpp | 5 -----\n 1 file changed, 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex aa4542ed26b1..7e89e3921dbe 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -312,8 +312,6 @@ private:\n \tstd::map entities_;\n \n \tMediaDevice *converter_;\n-\n-\tCamera *activeCamera_;\n };\n \n /* -----------------------------------------------------------------------------\n@@ -1025,8 +1023,6 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL\n \t\t\tvideo->queueBuffer(buffer.get());\n \t}\n \n-\tactiveCamera_ = camera;\n-\n \treturn 0;\n }\n \n@@ -1044,7 +1040,6 @@ void SimplePipelineHandler::stop(Camera *camera)\n \tvideo->bufferReady.disconnect(data, &SimpleCameraData::bufferReady);\n \n \tdata->converterBuffers_.clear();\n-\tactiveCamera_ = nullptr;\n \n \treleasePipeline(data);\n }\n","prefixes":["libcamera-devel","10/10"]}