{"id":13205,"url":"https://patchwork.libcamera.org/api/1.1/patches/13205/?format=json","web_url":"https://patchwork.libcamera.org/patch/13205/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210805083551.234027-2-umang.jain@ideasonboard.com>","date":"2021-08-05T08:35:51","name":"[libcamera-devel,2/2] android: mm: cros_camera_buffer: Fix unused parameter","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4d7f35af9718d16d928115986884857e66faeafd","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13205/mbox/","series":[{"id":2305,"url":"https://patchwork.libcamera.org/api/1.1/series/2305/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2305","date":"2021-08-05T08:35:51","name":null,"version":1,"mbox":"https://patchwork.libcamera.org/series/2305/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13205/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13205/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FB21C3235\n\tfor ;\n\tThu, 5 Aug 2021 08:36:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0AD76880F;\n\tThu, 5 Aug 2021 10:36:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6A9F687CB\n\tfor ;\n\tThu, 5 Aug 2021 10:36:05 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.40])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E7DAE1A;\n\tThu, 5 Aug 2021 10:36:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kG04bZ+P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628152565;\n\tbh=ljDT0ojHAv/lh+/fkmzLQjcMqVFCX3K7MsIuWGC2qm4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kG04bZ+PqTG7bxPGioFU/YbE2rmx9BkzgHBt7GeInKkbvMRuOfp/H/2jUVcna6jen\n\tHnZqP+AS3rEK7DwwhORy8xWaDZNDHz17grL+3UxsmIfYS8EVlD9x4TtmW75yJS46Y7\n\tqY/ZedPt3S/0gNrT1jSXNZC8A74kzDOo9pYqRD5k=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 5 Aug 2021 14:05:51 +0530","Message-Id":"<20210805083551.234027-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210805083551.234027-1-umang.jain@ideasonboard.com>","References":"<20210805083551.234027-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] android: mm: cros_camera_buffer: Fix\n\tunused parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Hirokazu Honda \n\ncameraBuffer function in private constructor is unused.\nMark it as such.\n\nFixes: 33dd4fab9d39(\"libcamera: base: class: Don't pass Extensible\n\t\t pointer to Private constructor\")\nSigned-off-by: Hirokazu Honda \nReviewed-by: Umang Jain \nSigned-off-by: Umang Jain \n---\n src/android/mm/cros_camera_buffer.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\nindex 437502fb..e8783ff8 100644\n--- a/src/android/mm/cros_camera_buffer.cpp\n+++ b/src/android/mm/cros_camera_buffer.cpp\n@@ -44,7 +44,7 @@ private:\n \t} mem;\n };\n \n-CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n+CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer,\n \t\t\t buffer_handle_t camera3Buffer,\n \t\t\t [[maybe_unused]] int flags)\n \t: handle_(camera3Buffer), numPlanes_(0), valid_(false),\n","prefixes":["libcamera-devel","2/2"]}