{"id":13104,"url":"https://patchwork.libcamera.org/api/1.1/patches/13104/?format=json","web_url":"https://patchwork.libcamera.org/patch/13104/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210723040421.1898-1-laurent.pinchart@ideasonboard.com>","date":"2021-07-23T04:04:21","name":"[libcamera-devel] cam: Initialize CamApp::loopUsers_","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e475aaa5c9b92244d7e4b6bd8bb8716d0a570658","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13104/mbox/","series":[{"id":2271,"url":"https://patchwork.libcamera.org/api/1.1/series/2271/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2271","date":"2021-07-23T04:04:21","name":"[libcamera-devel] cam: Initialize CamApp::loopUsers_","version":1,"mbox":"https://patchwork.libcamera.org/series/2271/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13104/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13104/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6F82C0109\n\tfor ;\n\tFri, 23 Jul 2021 04:04:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13D6E687A9;\n\tFri, 23 Jul 2021 06:04:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC428687A3\n\tfor ;\n\tFri, 23 Jul 2021 06:04:27 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BE93255\n\tfor ;\n\tFri, 23 Jul 2021 06:04:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sme49bzP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627013067;\n\tbh=Ew3xPXCe3ydw5mLkoXEPA9EdJqNIV3TKZ5fhKEcP8y8=;\n\th=From:To:Subject:Date:From;\n\tb=sme49bzPdQbzqoXeQYMd7sJbe5ljUHg9lx6NjQdNG3tANtshZaKfhNGmmrO2RHoJu\n\t3mknVK7Jrh2w+2D2kkFiLwSQqCm00N8vrbxuGilGyn3CYTNk3o2OVSkiyjlUnOQ4Z8\n\t6/jpHH0Q3+It2xNKH29lymr5ZzJngZUTNY8avruY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 23 Jul 2021 07:04:21 +0300","Message-Id":"<20210723040421.1898-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] cam: Initialize CamApp::loopUsers_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CamApp loopUsers_ member variable isn't initialized, which results\nin random execution of the event loop. Fix it.\n\nFixes: caa6ffacb2fc (\"cam: Reorganize run() function and merge the two event loops\")\nSigned-off-by: Laurent Pinchart \n---\n src/cam/main.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex f9a90672a474..34cbc3229563 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -56,6 +56,7 @@ private:\n CamApp *CamApp::app_ = nullptr;\n \n CamApp::CamApp()\n+\t: loopUsers_(0)\n {\n \tCamApp::app_ = this;\n }\n","prefixes":["libcamera-devel"]}