{"id":13088,"url":"https://patchwork.libcamera.org/api/1.1/patches/13088/?format=json","web_url":"https://patchwork.libcamera.org/patch/13088/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210723040036.32346-3-laurent.pinchart@ideasonboard.com>","date":"2021-07-23T04:00:21","name":"[libcamera-devel,RFC,02/17] libcamera: base: class: Link LIBCAMERA_O_PTR to Extensible documentation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b2f103557053e6a74f4bc8fa7bd65d8c1079c182","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13088/mbox/","series":[{"id":2270,"url":"https://patchwork.libcamera.org/api/1.1/series/2270/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2270","date":"2021-07-23T04:00:19","name":"libcamera: Replace CameraData with Camera::Private","version":1,"mbox":"https://patchwork.libcamera.org/series/2270/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13088/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13088/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DA9BC322B\n\tfor ;\n\tFri, 23 Jul 2021 04:00:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B102B6877A;\n\tFri, 23 Jul 2021 06:00:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEA906877B\n\tfor ;\n\tFri, 23 Jul 2021 06:00:43 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B73451D\n\tfor ;\n\tFri, 23 Jul 2021 06:00:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hqPQOeTn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627012843;\n\tbh=zZ4eRByRelK4Hy7sB2jnK1mah6FZXElm/2tCUqnfzeI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=hqPQOeTnYwm9GB1LGoIo7QfcEn2PrFQ4ThoC9/QE74n55WqJGo8mH8SyAaXSNqFEd\n\ttc0E8m6JzB0HG8+qJ4SfPGB6G4qmx7qVQ1q5tOPZk1CxEnemWG+SsDGlL5nVPFnVK2\n\t+frr8x/FSMU4Zi+CZJQH4kOI/3zRrlvEtJyuCNTk=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 23 Jul 2021 07:00:21 +0300","Message-Id":"<20210723040036.32346-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>","References":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 02/17] libcamera: base: class: Link\n\tLIBCAMERA_O_PTR to Extensible documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The LIBCAMERA_O_PTR macro is part of the Extensible class\ninfrastructure, but doesn't link to it. This makes the generated\ndocumentation unclear. Fix it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/base/class.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/base/class.cpp b/src/libcamera/base/class.cpp\nindex d0899671ca11..d4f0ac64ad48 100644\n--- a/src/libcamera/base/class.cpp\n+++ b/src/libcamera/base/class.cpp\n@@ -98,8 +98,9 @@ namespace libcamera {\n * \\def LIBCAMERA_O_PTR()\n * \\brief Retrieve the public instance corresponding to the private data\n *\n- * This macro is used in any member function of the private data class to access\n- * the public class instance corresponding to the private data.\n+ * This macro is part of the libcamera::Extensible class infrastructure. It may\n+ * be used in any member function of a libcamera::Extensible::Private subclass\n+ * to access the public class instance corresponding to the private data.\n */\n \n /**\n@@ -139,6 +140,8 @@ namespace libcamera {\n * protected and private members.\n *\n * The PublicClass exposes its Private data pointer through the _d() function.\n+ * In the other direction, the pointer to the PublicClass can be retrieved in\n+ * functions of the Private class using the LIBCAMERA_O_PTR() macro.\n */\n \n /**\n","prefixes":["libcamera-devel","RFC","02/17"]}