{"id":13085,"url":"https://patchwork.libcamera.org/api/1.1/patches/13085/?format=json","web_url":"https://patchwork.libcamera.org/patch/13085/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210722232851.747614-12-nfraprado@collabora.com>","date":"2021-07-22T23:28:51","name":"[libcamera-devel,v7,11/11] lc-compliance: Add test to ensure MinimumRequests is valid","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e1822afb56fa07fc1823c69bda6c59455a97a23c","submitter":{"id":84,"url":"https://patchwork.libcamera.org/api/1.1/people/84/?format=json","name":"Nícolas F. R. A. Prado","email":"nfraprado@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13085/mbox/","series":[{"id":2269,"url":"https://patchwork.libcamera.org/api/1.1/series/2269/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2269","date":"2021-07-22T23:28:40","name":"lc-compliance: Add test to queue more requests than hardware depth","version":7,"mbox":"https://patchwork.libcamera.org/series/2269/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13085/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13085/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92C75C0109\n\tfor ;\n\tThu, 22 Jul 2021 23:29:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 617CB687A7;\n\tFri, 23 Jul 2021 01:29:50 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF1E960276\n\tfor ;\n\tFri, 23 Jul 2021 01:29:48 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2804:14c:1a9:2434:a4c5:aa5e:1d8c:5e2c])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id E64971F447CE;\n\tFri, 23 Jul 2021 00:29:46 +0100 (BST)"],"From":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jul 2021 20:28:51 -0300","Message-Id":"<20210722232851.747614-12-nfraprado@collabora.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210722232851.747614-1-nfraprado@collabora.com>","References":"<20210722232851.747614-1-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v7 11/11] lc-compliance: Add test to\n\tensure MinimumRequests is valid","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel@collabora.com, =?utf-8?q?Andr=C3=A9_Almeida?=\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a test in lc-compliance to check that the MinimumRequests property\nis set and valid, that is, greater than 0.\n\nSigned-off-by: Nícolas F. R. A. Prado \n---\n\nAdded in v7\n\n src/lc-compliance/capture_test.cpp | 27 +++++++++++++++++++++++++++\n 1 file changed, 27 insertions(+)","diff":"diff --git a/src/lc-compliance/capture_test.cpp b/src/lc-compliance/capture_test.cpp\nindex a7ba7448a21b..8d0da770e901 100644\n--- a/src/lc-compliance/capture_test.cpp\n+++ b/src/lc-compliance/capture_test.cpp\n@@ -101,6 +101,23 @@ void RoleParametrizedTest::TearDown()\n \treleaseCamera();\n }\n \n+class CameraTests : public ::testing::Test, public CameraHolder\n+{\n+protected:\n+\tvoid SetUp() override;\n+\tvoid TearDown() override;\n+};\n+\n+void CameraTests::SetUp()\n+{\n+\tacquireCamera();\n+}\n+\n+void CameraTests::TearDown()\n+{\n+\treleaseCamera();\n+}\n+\n std::string SingleStream::nameParameters(const testing::TestParamInfo &info)\n {\n \treturn roleToString(std::get<0>(info.param)) + \"_\" +\n@@ -187,6 +204,16 @@ TEST_P(RoleParametrizedTest, Overflow)\n \tcapture.capture();\n }\n \n+TEST_F(CameraTests, RequiredProperties)\n+{\n+\tconst ControlList &properties = camera_->properties();\n+\n+\tusing namespace properties;\n+\n+\tEXPECT_GT(properties.get(MinimumRequests), 0)\n+\t\t<< \"Camera should have a positive value for MinimumRequests property\";\n+}\n+\n INSTANTIATE_TEST_SUITE_P(CaptureTests,\n \t\t\t SingleStream,\n \t\t\t testing::Combine(testing::ValuesIn(ROLES),\n","prefixes":["libcamera-devel","v7","11/11"]}