{"id":13058,"url":"https://patchwork.libcamera.org/api/1.1/patches/13058/?format=json","web_url":"https://patchwork.libcamera.org/patch/13058/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210720101307.26010-10-paul.elder@ideasonboard.com>","date":"2021-07-20T10:13:07","name":"[libcamera-devel,v5,9/9] android, controls: Add and plumb MaxLatency control","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ccdcb6582b009b103c0d4b4c8abd0c1775682419","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13058/mbox/","series":[{"id":2258,"url":"https://patchwork.libcamera.org/api/1.1/series/2258/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2258","date":"2021-07-20T10:12:58","name":"android: Support capability and hardware level detection","version":5,"mbox":"https://patchwork.libcamera.org/series/2258/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13058/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13058/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32289C0109\n\tfor ;\n\tTue, 20 Jul 2021 10:13:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5F7068536;\n\tTue, 20 Jul 2021 12:13:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 954AE68547\n\tfor ;\n\tTue, 20 Jul 2021 12:13:38 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 937FA443;\n\tTue, 20 Jul 2021 12:13:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HaNPIqEf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626776018;\n\tbh=czes8D+IRFHoIjzwO7glNFtCkmRWn6OMXtUdhOZwcuw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HaNPIqEf1yxeSLKa93eySX9+0UljRj31Idw44MI8Eh0N1Pidwu/jTup0ZTpyeu4dp\n\tBN5Rd4NXTGUo4/j68mtiYs10jwgxVvjElC7kcgI8UKntDWyshxDC52crd7bXNtg/aO\n\tfDIBbgHOBPYwFeDMZswHZdSSyvzJ8iymzX2ok7QY=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Jul 2021 19:13:07 +0900","Message-Id":"<20210720101307.26010-10-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210720101307.26010-1-paul.elder@ideasonboard.com>","References":"<20210720101307.26010-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 9/9] android,\n\tcontrols: Add and plumb MaxLatency control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a MaxLatency control, and plumb it into the HAL accordingly.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=50\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \n\n---\nChanges in v3:\n- use v3 setMetadata\n- add comment to explain 4\n- remove todo\n\nChanges in v2:\n- use new setMetadata\n- rebase on camera capabilities refactor\n---\n src/android/camera_capabilities.cpp | 7 +++++--\n src/libcamera/control_ids.yaml | 10 ++++++++++\n 2 files changed, 15 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 8c425138..5010289b 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1130,8 +1130,11 @@ int CameraCapabilities::initializeStaticMetadata()\n \t}\n \n \t/* Sync static metadata. */\n-\tint32_t maxLatency = ANDROID_SYNC_MAX_LATENCY_UNKNOWN;\n-\tstaticMetadata_->addEntry(ANDROID_SYNC_MAX_LATENCY, maxLatency);\n+\tsetMetadata(\n+\t\tstaticMetadata_.get(), ANDROID_SYNC_MAX_LATENCY,\n+\t\tcontrolsInfo, &controls::draft::MaxLatency,\n+\t\tControlRange::Def,\n+\t\tANDROID_SYNC_MAX_LATENCY_UNKNOWN);\n \n \t/* Flash static metadata. */\n \tchar flashAvailable = ANDROID_FLASH_INFO_AVAILABLE_FALSE;\ndiff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex d92f29f5..9d4638ae 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -622,6 +622,16 @@ controls:\n detection, additional format conversions etc) count as an additional\n pipeline stage.\n \n+ - MaxLatency:\n+ type: int32_t\n+ draft: true\n+ description: |\n+ The maximum number of frames that can occur after a request (different\n+ than the previous) has been submitted, and before the result's state\n+ becomes synchronized. A value of -1 indicates unknown latency, and 0\n+ indicates per-frame control. Currently identical to\n+ ANDROID_SYNC_MAX_LATENCY.\n+\n - TestPatternMode:\n type: int32_t\n draft: true\n","prefixes":["libcamera-devel","v5","9/9"]}