{"id":13054,"url":"https://patchwork.libcamera.org/api/1.1/patches/13054/?format=json","web_url":"https://patchwork.libcamera.org/patch/13054/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210720101307.26010-6-paul.elder@ideasonboard.com>","date":"2021-07-20T10:13:03","name":"[libcamera-devel,v6,5/9] android: Add infrastructure for determining capabilities and hardware level","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6ebe4d985303796becaac72b74a587affc845aa6","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13054/mbox/","series":[{"id":2258,"url":"https://patchwork.libcamera.org/api/1.1/series/2258/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2258","date":"2021-07-20T10:12:58","name":"android: Support capability and hardware level detection","version":5,"mbox":"https://patchwork.libcamera.org/series/2258/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13054/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13054/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70AAAC0109\n\tfor ;\n\tTue, 20 Jul 2021 10:13:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34D3D6854B;\n\tTue, 20 Jul 2021 12:13:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC98B68521\n\tfor ;\n\tTue, 20 Jul 2021 12:13:29 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DAA3443;\n\tTue, 20 Jul 2021 12:13:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qV2aSBf9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626776009;\n\tbh=h6yH//HaMU1rt8p2EyZSeEeXxJWP9BWQ68biLtq7QOk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qV2aSBf9WmtWgRRCZVEstHmIkLKswI8DYTthpqEUuOHRfpZaIErRRmDeaAoJfbriw\n\tqegiONJHMpty6K45EGRus9PXXZVcDpfhpc0D+2oywz9GjIxc/sA/8agRgicxNBYGzN\n\tXd2cCFukV7OOCofAwzVxK+8pw7+2jFq+TY26eq3U=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Jul 2021 19:13:03 +0900","Message-Id":"<20210720101307.26010-6-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210720101307.26010-1-paul.elder@ideasonboard.com>","References":"<20210720101307.26010-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 5/9] android: Add infrastructure for\n\tdetermining capabilities and hardware level","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add the infrastructure for checking and reporting capabilities. Use\nthese capabilities to determine the hardware level as well.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=55\nSigned-off-by: Paul Elder \n\n---\nI'm thinking that we should hardcode the validate* functions to return\nfalse for now until we add all the required capabilities. They cannot\nreturn true anyway until that happens.\n\nChanges in v6:\n- make all args const\n- convert the caps list from set to vector\n\nChanges in v5:\n- change the whole thing to turn on capabilities after they are all\n confirmed, instead of disabling them as conditions are not met\n\nChanges in v4:\n- rebase on camera capabilities refactoring\n- switch to std::set from std::map\n- make hwlevel similar to capabilities\n\nChanges in v3:\n- fix some compiler errors\n- go ahead and initialize the capabilities to true, update the commit\n message accordingly\n\nChanges in v2:\n- add a flag for FULL, since there are a few requirements that are not\n obtained from capabilities alone\n- add burst capture capability, since that is required for FULL as well\n---\n src/android/camera_capabilities.cpp | 174 +++++++++++++++++++++++++---\n src/android/camera_capabilities.h | 12 ++\n 2 files changed, 171 insertions(+), 15 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 9e2714f1..c97a17e6 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -7,8 +7,10 @@\n \n #include \"camera_capabilities.h\"\n \n+#include \n #include \n #include \n+#include \n \n #include \n \n@@ -114,8 +116,153 @@ const std::map camera3FormatsMap = {\n \t},\n };\n \n+const std::map\n+hwLevelStrings = {\n+\t{ ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED, \"LIMITED\" },\n+\t{ ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL, \"FULL\" },\n+\t{ ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LEGACY, \"LEGACY\" },\n+\t{ ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_3, \"LEVEL_3\" },\n+\t{ ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_EXTERNAL, \"EXTERNAL\" },\n+};\n+\n } /* namespace */\n \n+bool CameraCapabilities::validateManualSensorCapability(const CameraMetadata *staticMetadata)\n+{\n+\tcamera_metadata_ro_entry_t entry;\n+\tbool found;\n+\n+\tconst char *noMode = \"Manual sensor capability unavailable: \";\n+\n+\tif (!(found = staticMetadata->entryContains(ANDROID_CONTROL_AE_AVAILABLE_MODES,\n+\t\t\t\t\t\t\t ANDROID_CONTROL_AE_MODE_OFF))) {\n+\t\tLOG(HAL, Info)\n+\t\t\t<< noMode << \"missing AE mode off: \"\n+\t\t\t<< (found ? \"not supported\" : \"not found\");\n+\t\treturn false;\n+\t}\n+\n+\tfound = staticMetadata->getEntry(ANDROID_CONTROL_AE_LOCK_AVAILABLE,\n+\t\t\t\t\t &entry);\n+\tif (!found || !(*entry.data.u8 == ANDROID_CONTROL_AE_LOCK_AVAILABLE_TRUE)) {\n+\t\tLOG(HAL, Info) << noMode << \"missing AE lock\";\n+\t\treturn false;\n+\t}\n+\n+\treturn true;\n+}\n+\n+bool CameraCapabilities::validateManualPostProcessingCapability(const CameraMetadata *staticMetadata)\n+{\n+\tcamera_metadata_ro_entry_t entry;\n+\tbool found;\n+\n+\tconst char *noMode = \"Manual post processing capability unavailable: \";\n+\n+\tif (!staticMetadata->entryContains(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n+\t\t\t\t\t\t ANDROID_CONTROL_AWB_MODE_OFF)) {\n+\t\tLOG(HAL, Info) << noMode << \"missing AWB mode off\";\n+\t\treturn false;\n+\t}\n+\n+\tfound = staticMetadata->getEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n+\t\t\t\t\t &entry);\n+\tif (!found || !(*entry.data.u8 == ANDROID_CONTROL_AWB_LOCK_AVAILABLE_TRUE)) {\n+\t\tLOG(HAL, Info) << noMode << \"missing AWB lock\";\n+\t\treturn false;\n+\t}\n+\n+\treturn true;\n+}\n+\n+bool CameraCapabilities::validateBurstCaptureCapability(const CameraMetadata *staticMetadata)\n+{\n+\tcamera_metadata_ro_entry_t entry;\n+\tbool found;\n+\n+\tconst char *noMode = \"Burst capture capability unavailable: \";\n+\n+\tfound = staticMetadata->getEntry(ANDROID_CONTROL_AE_LOCK_AVAILABLE,\n+\t\t\t\t\t &entry);\n+\tif (!found || !(*entry.data.u8 == ANDROID_CONTROL_AE_LOCK_AVAILABLE_TRUE)) {\n+\t\tLOG(HAL, Info) << noMode << \"missing AE lock\";\n+\t\treturn false;\n+\t}\n+\n+\tfound = staticMetadata->getEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n+\t\t\t\t\t &entry);\n+\tif (!found || !(*entry.data.u8 == ANDROID_CONTROL_AWB_LOCK_AVAILABLE_TRUE)) {\n+\t\tLOG(HAL, Info) << noMode << \"missing AWB lock\";\n+\t\treturn false;\n+\t}\n+\n+\tfound = staticMetadata->getEntry(ANDROID_SYNC_MAX_LATENCY, &entry);\n+\tif (!found || *entry.data.i32 < 0 || 4 < *entry.data.i32) {\n+\t\tLOG(HAL, Info)\n+\t\t\t<< noMode << \"max sync latency is \"\n+\t\t\t<< (found ? std::to_string(*entry.data.i32) : \"not present\");\n+\t\treturn false;\n+\t}\n+\n+\treturn true;\n+}\n+\n+std::vector\n+CameraCapabilities::computeCapabilities(const CameraMetadata *staticMetadata)\n+{\n+\tstd::vector\n+\t\tcapabilities;\n+\n+\tcapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE);\n+\n+\tif (validateManualSensorCapability(staticMetadata))\n+\t\tcapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);\n+\n+\tif (validateManualPostProcessingCapability(staticMetadata))\n+\t\tcapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING);\n+\n+\tif (validateBurstCaptureCapability(staticMetadata))\n+\t\tcapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE);\n+\n+\tif (rawStreamAvailable_)\n+\t\tcapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW);\n+\n+\treturn capabilities;\n+}\n+\n+camera_metadata_enum_android_info_supported_hardware_level\n+CameraCapabilities::computeHwLevel(const CameraMetadata *staticMetadata,\n+\tconst std::vector &caps)\n+{\n+\tcamera_metadata_ro_entry_t entry;\n+\tbool found;\n+\tcamera_metadata_enum_android_info_supported_hardware_level\n+\t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL;\n+\n+\tif (std::find(caps.begin(), caps.end(),\n+\t\t ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR) == caps.end()) {\n+\t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n+\n+\tif (std::find(caps.begin(), caps.end(),\n+\t\t ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING) == caps.end()) {\n+\t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n+\n+\tif (std::find(caps.begin(), caps.end(),\n+\t\t ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE) == caps.end()) {\n+\t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n+\n+\tfound = staticMetadata->getEntry(ANDROID_SYNC_MAX_LATENCY, &entry);\n+\tif (!found || *entry.data.i32 != 0)\n+\t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\n+\thwLevel_ = hwLevel;\n+\n+\treturn hwLevel;\n+}\n+\n int CameraCapabilities::initialize(std::shared_ptr camera,\n \t\t\t\t int orientation, int facing)\n {\n@@ -840,11 +987,6 @@ int CameraCapabilities::initializeStaticMetadata()\n \tuint8_t croppingType = ANDROID_SCALER_CROPPING_TYPE_CENTER_ONLY;\n \tstaticMetadata_->addEntry(ANDROID_SCALER_CROPPING_TYPE, croppingType);\n \n-\t/* Info static metadata. */\n-\tuint8_t supportedHWLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n-\tstaticMetadata_->addEntry(ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n-\t\t\t\t supportedHWLevel);\n-\n \t/* Request static metadata. */\n \tint32_t partialResultCount = 1;\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n@@ -865,21 +1007,23 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n \t\t\t\t maxNumInputStreams);\n \n-\tstd::vector availableCapabilities = {\n-\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n-\t};\n-\n-\t/* Report if camera supports RAW. */\n-\tif (rawStreamAvailable_)\n-\t\t\tavailableCapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW);\n-\n \t/* Number of { RAW, YUV, JPEG } supported output streams */\n \tint32_t numOutStreams[] = { rawStreamAvailable_, 2, 1 };\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n \t\t\t\t numOutStreams);\n \n-\tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n-\t\t\t\t availableCapabilities);\n+\t/* Check capabilities */\n+\tstd::vector\n+\t\tcapabilities = computeCapabilities(staticMetadata_.get());\n+\tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capabilities);\n+\n+\tcamera_metadata_enum_android_info_supported_hardware_level hwLevel =\n+\t\tcomputeHwLevel(staticMetadata_.get(), capabilities);\n+\tstaticMetadata_->addEntry(ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL, hwLevel);\n+\n+\tLOG(HAL, Info)\n+\t\t<< \"Hardware level: \"\n+\t\t<< hwLevelStrings.find((camera_metadata_enum_android_info_supported_hardware_level)hwLevel)->second;\n \n \tstd::vector availableCharacteristicsKeys = {\n \t\tANDROID_COLOR_CORRECTION_AVAILABLE_ABERRATION_MODES,\ndiff --git a/src/android/camera_capabilities.h b/src/android/camera_capabilities.h\nindex 42a976d3..6ef81714 100644\n--- a/src/android/camera_capabilities.h\n+++ b/src/android/camera_capabilities.h\n@@ -42,6 +42,17 @@ private:\n \t\tint androidFormat;\n \t};\n \n+\tbool validateManualSensorCapability(const CameraMetadata *staticMetadata);\n+\tbool validateManualPostProcessingCapability(const CameraMetadata *staticMetadata);\n+\tbool validateBurstCaptureCapability(const CameraMetadata *staticMetadata);\n+\n+\tstd::vector\n+\t\tcomputeCapabilities(const CameraMetadata *staticMetadata);\n+\n+\tcamera_metadata_enum_android_info_supported_hardware_level\n+\t\tcomputeHwLevel(const CameraMetadata *staticMetadata,\n+\t\t\tconst std::vector &caps);\n+\n \tstd::vector\n \tinitializeYUVResolutions(const libcamera::PixelFormat &pixelFormat,\n \t\t\t\t const std::vector &resolutions);\n@@ -56,6 +67,7 @@ private:\n \tint facing_;\n \tint orientation_;\n \tbool rawStreamAvailable_;\n+\tcamera_metadata_enum_android_info_supported_hardware_level hwLevel_;\n \n \tstd::vector streamConfigurations_;\n \tstd::map formatsMap_;\n","prefixes":["libcamera-devel","v6","5/9"]}