{"id":13042,"url":"https://patchwork.libcamera.org/api/1.1/patches/13042/?format=json","web_url":"https://patchwork.libcamera.org/patch/13042/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210719101437.326523-3-umang.jain@ideasonboard.com>","date":"2021-07-19T10:14:37","name":"[libcamera-devel] imx258: Read analog gain register values","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"cfe821fc7118c012adc724d242bca7f70bc1279e","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13042/mbox/","series":[{"id":2254,"url":"https://patchwork.libcamera.org/api/1.1/series/2254/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2254","date":"2021-07-19T10:14:37","name":"[libcamera-devel] imx258: Read analog gain register values","version":1,"mbox":"https://patchwork.libcamera.org/series/2254/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13042/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13042/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87378C322B\n\tfor ;\n\tMon, 19 Jul 2021 10:15:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4926B68538;\n\tMon, 19 Jul 2021 12:15:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D66D468537\n\tfor ;\n\tMon, 19 Jul 2021 12:14:59 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.64])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C2735465;\n\tMon, 19 Jul 2021 12:14:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oMbR8cJA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626689699;\n\tbh=4sONJ6spI0CxKT2VYs23ggHpHMCOr3OPkMGOPft1f8E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oMbR8cJAdMTFRN+NfBr/SrSQn67qR9bjoSskG6fdil1vsKVOFHdqTlKguVCk3+NhT\n\tLjnsJx6om0YizGgHtj19ZYVHCLq+FAK5MAKGOfns4lb3F3lx6VEf96rkXs/vxH9qgp\n\tyod2TcOO7/+y8238rDUWTZTubwX1aQNKzsInlGjE=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 19 Jul 2021 15:44:37 +0530","Message-Id":"<20210719101437.326523-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210719101437.326523-1-umang.jain@ideasonboard.com>","References":"<20210719101437.326523-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] imx258: Read analog gain register values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Also copy and tweak imx258_read_reg() to allow signed int values.\n(These constants are signed ints).\n\n---\n drivers/media/i2c/imx258.c | 78 ++++++++++++++++++++++++++++++++++++++\n 1 file changed, 78 insertions(+)","diff":"diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c\nindex f86ae18bc104..d029706f4d51 100644\n--- a/drivers/media/i2c/imx258.c\n+++ b/drivers/media/i2c/imx258.c\n@@ -21,6 +21,13 @@\n #define IMX258_REG_CHIP_ID\t\t0x0016\n #define IMX258_CHIP_ID\t\t\t0x0258\n \n+/* Gain constant registers */\n+#define IMX258_REG_GAIN_CAP\t\t0x0080\n+#define IMX258_REG_C0\t\t\t0x008E\n+#define IMX258_REG_M0\t\t\t0x008C\n+#define IMX258_REG_C1\t\t\t0x0092\n+#define IMX258_REG_M1\t\t\t0x0090\n+\n /* V_TIMING internal */\n #define IMX258_VTS_30FPS\t\t0x0c98\n #define IMX258_VTS_30FPS_2K\t\t0x0638\n@@ -650,6 +657,38 @@ static int imx258_read_reg(struct imx258 *imx258, u16 reg, u32 len, u32 *val)\n \treturn 0;\n }\n \n+static int imx258_read_reg_signed(struct imx258 *imx258, u16 reg, u32 len, int16_t *val)\n+{\n+\tstruct i2c_client *client = v4l2_get_subdevdata(&imx258->sd);\n+\tstruct i2c_msg msgs[2];\n+\tu8 addr_buf[2] = { reg >> 8, reg & 0xff };\n+\tu8 data_buf[4] = { 0, };\n+\tint ret;\n+\n+\tif (len > 4)\n+\t\treturn -EINVAL;\n+\n+\t/* Write register address */\n+\tmsgs[0].addr = client->addr;\n+\tmsgs[0].flags = 0;\n+\tmsgs[0].len = ARRAY_SIZE(addr_buf);\n+\tmsgs[0].buf = addr_buf;\n+\n+\t/* Read data from register */\n+\tmsgs[1].addr = client->addr;\n+\tmsgs[1].flags = I2C_M_RD;\n+\tmsgs[1].len = len;\n+\tmsgs[1].buf = &data_buf[4 - len];\n+\n+\tret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));\n+\tif (ret != ARRAY_SIZE(msgs))\n+\t\treturn -EIO;\n+\n+\t*val = get_unaligned_be32(data_buf);\n+\n+\treturn 0;\n+}\n+\n /* Write registers up to 2 at a time */\n static int imx258_write_reg(struct imx258 *imx258, u16 reg, u32 len, u32 val)\n {\n@@ -1055,6 +1094,7 @@ static int imx258_identify_module(struct imx258 *imx258)\n \tstruct i2c_client *client = v4l2_get_subdevdata(&imx258->sd);\n \tint ret;\n \tu32 val;\n+\tint16_t value;\n \n \tret = imx258_read_reg(imx258, IMX258_REG_CHIP_ID,\n \t\t\t IMX258_REG_VALUE_16BIT, &val);\n@@ -1070,6 +1110,44 @@ static int imx258_identify_module(struct imx258 *imx258)\n \t\treturn -EIO;\n \t}\n \n+\t// Hijack this to also read analog gain registers and print values\n+\tdev_info(&client->dev, \"Reading analog gain registers...\\n\");\n+\n+\tret = imx258_read_reg(imx258, IMX258_REG_GAIN_CAP, IMX258_REG_VALUE_16BIT, &val);\n+\tif (ret) {\n+\t\tdev_err(&client->dev, \"failed to read GAIN_CAP %x\\n\",\n+\t\t\tIMX258_REG_GAIN_CAP);\n+\t}\n+\tdev_info(&client->dev, \"Value of analog Gain capability: %d\\n\", val);\n+\n+\tret = imx258_read_reg_signed(imx258, IMX258_REG_C0, IMX258_REG_VALUE_16BIT, &value);\n+\tif (ret) {\n+\t\tdev_err(&client->dev, \"failed to read C0 %x\\n\",\n+\t\t\tIMX258_REG_C0);\n+\t}\n+\tdev_info(&client->dev, \"Value of C0: %d\\n\", value);\n+\n+\tret = imx258_read_reg_signed(imx258, IMX258_REG_M0, IMX258_REG_VALUE_16BIT, &value);\n+\tif (ret) {\n+\t\tdev_err(&client->dev, \"failed to read M0 %x\\n\",\n+\t\t\tIMX258_REG_M0);\n+\t}\n+\tdev_info(&client->dev, \"Value of M0: %d\\n\", value);\n+\n+\tret = imx258_read_reg_signed(imx258, IMX258_REG_C1, IMX258_REG_VALUE_16BIT, &value);\n+\tif (ret) {\n+\t\tdev_err(&client->dev, \"failed to read C1 %x\\n\",\n+\t\t\tIMX258_REG_C1);\n+\t}\n+\tdev_info(&client->dev, \"Value of C1: %d\\n\", value);\n+\n+\tret = imx258_read_reg_signed(imx258, IMX258_REG_M1, IMX258_REG_VALUE_16BIT, &value);\n+\tif (ret) {\n+\t\tdev_err(&client->dev, \"failed to read M1 %x\\n\",\n+\t\t\tIMX258_REG_M1);\n+\t}\n+\tdev_info(&client->dev, \"Value of M1: %d\\n\", value);\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel"]}