{"id":13041,"url":"https://patchwork.libcamera.org/api/1.1/patches/13041/?format=json","web_url":"https://patchwork.libcamera.org/patch/13041/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210719101437.326523-2-umang.jain@ideasonboard.com>","date":"2021-07-19T10:14:36","name":"[libcamera-devel,1/1] libipa: Add CameraSensorHelper for IMX258","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"f18d439f1ce14ed7f9ab09db23b8a33d447fbe42","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13041/mbox/","series":[{"id":2253,"url":"https://patchwork.libcamera.org/api/1.1/series/2253/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2253","date":"2021-07-19T10:14:35","name":"Add CameraSensorHelper for IMX258","version":1,"mbox":"https://patchwork.libcamera.org/series/2253/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13041/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13041/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EA56C322B\n\tfor ;\n\tMon, 19 Jul 2021 10:14:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B95AC68539;\n\tMon, 19 Jul 2021 12:14:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9665C6853C\n\tfor ;\n\tMon, 19 Jul 2021 12:14:57 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.64])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EAD4465;\n\tMon, 19 Jul 2021 12:14:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZtwgAOrA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626689697;\n\tbh=QbA9EnvhHWA2aAAaqwmJvgxUV11yvNUeyty1RZN9eGY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZtwgAOrACtJfV2W0B0/nGDw+lbIa+4TBS9VRI6FtXzS5Drx1MR9oc14gvXSRvQDVZ\n\tSqz51dfmZ//eoMXcJklDkPnB5fHy+0JOAuYqUXVC71Pk1qG6p52hBi/sV8NQSTkVgC\n\tew0GOgMYlL68fBcfdRVWE9bLXYP8bcWVr3TtnOG0=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 19 Jul 2021 15:44:36 +0530","Message-Id":"<20210719101437.326523-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210719101437.326523-1-umang.jain@ideasonboard.com>","References":"<20210719101437.326523-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/1] libipa: Add CameraSensorHelper for\n\tIMX258","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Extend the CameraSensorHelper factory with support for an\nIMX258 sensor as found in the Nautilus Chromebook.\n\nThe values are read by hacking the IMX258 kernel driver.\nThe values for analog gain constants are obtained by reading the\nregister indexes, corresponding to the analog gain constants, as\nmentioned in MIPI CCS v1.1 specification.\n\nSigned-off-by: Umang Jain \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 709835a8..c43368df 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -295,6 +295,16 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx219\", CameraSensorHelperImx219)\n \n+class CameraSensorHelperImx258 : public CameraSensorHelper\n+{\n+public:\n+ CameraSensorHelperImx258()\n+ {\n+ analogueGainConstants_ = { AnalogueGainLinear, 0, 512, -1, 512 };\n+ }\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n+\n class CameraSensorHelperOv5670 : public CameraSensorHelper\n {\n public:\n","prefixes":["libcamera-devel","1/1"]}