{"id":13033,"url":"https://patchwork.libcamera.org/api/1.1/patches/13033/?format=json","web_url":"https://patchwork.libcamera.org/patch/13033/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210717182850.737833-1-vedantparanjape160201@gmail.com>","date":"2021-07-17T18:28:50","name":"[libcamera-devel,v1] gstreamer: Store group_id in GstLibcameraSrcState","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a3064890de850e9dfbcb3c419ab72b9cefe085db","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/1.1/people/85/?format=json","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13033/mbox/","series":[{"id":2248,"url":"https://patchwork.libcamera.org/api/1.1/series/2248/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2248","date":"2021-07-17T18:28:50","name":"[libcamera-devel,v1] gstreamer: Store group_id in GstLibcameraSrcState","version":1,"mbox":"https://patchwork.libcamera.org/series/2248/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13033/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13033/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8345BC0109\n\tfor ;\n\tSat, 17 Jul 2021 18:29:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C03B268516;\n\tSat, 17 Jul 2021 20:29:15 +0200 (CEST)","from mail-pg1-x533.google.com (mail-pg1-x533.google.com\n\t[IPv6:2607:f8b0:4864:20::533])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 574DF6027B\n\tfor ;\n\tSat, 17 Jul 2021 20:29:13 +0200 (CEST)","by mail-pg1-x533.google.com with SMTP id u14so13717631pga.11\n\tfor ;\n\tSat, 17 Jul 2021 11:29:13 -0700 (PDT)","from localhost.localdomain ([1.186.166.91])\n\tby smtp.googlemail.com with ESMTPSA id\n\tb19sm11633028pjh.29.2021.07.17.11.29.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 17 Jul 2021 11:29:11 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"paL3IZBu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Jba7hdzU6saWWlm150Xex6/yi4b4iC/zK83JsjffSQ0=;\n\tb=paL3IZBue6DYWRKZAHl7MGg2tEBvqQLKqzJTIkjg0W0gEZK41+UUuuW/o2/CJqfDjQ\n\tSxTkTO1LJQLleAwvKSI8pcL1a9/RyrfVLPFR54BE+MvSoPvUxPaFpMe3GIMzeXRsllOp\n\tfzmbRCIT3CeYygNiRufcTYfz5JqtIW8hPX0qWifIZ5oovwuhQVgeeDAbmZeVY4cJOwqv\n\tMFWru1X1HPrjvfQSGLspRZVaOzFH7Nmp81h92Od3MuFjQlkfYr1lKneo+laCx13qLEew\n\t2Dx+iCEPuom1IJO1Ilz3ELejKf9xVAlEp+2Vs8qBvKmZ9QfkUyUWtyvo8F7bvkNS65XM\n\tmW/g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Jba7hdzU6saWWlm150Xex6/yi4b4iC/zK83JsjffSQ0=;\n\tb=l4gVTSxMPqw6gEC66Z4nx5ORc20U8A7qRfNfIMxjU5nf8w25Y3gQkt4BHNMfFZDbJ9\n\tgPk1kmRefDB+eb/QWbebzEF8lLkPZvFmQbyTud/ipAMZXZIdUfAIybBeW+jFIIQI1cTo\n\tjFHTiWKr4fH7vxTj7lVqO3pEPQiiS+t3HXsGDYYSd7WCCDNnTuFi2HJIkqCQ4t+kBcxy\n\t4h4Ds+0vQATNKoBZYGO5+SfF3p54oNxn6HpgRYxlGJJGOfzeP5U0Yjlu2pExBUWZKC3Y\n\tSB7hybahuu+QmjXW9LRkVkOMJnLucQw4yOdmQo65wCEhePWKuguyX42FUejLKcH99kuH\n\tbPcQ==","X-Gm-Message-State":"AOAM533YhffAbm4Ddfvw/YdywegzkopDcjikCuZWDI3zxGh5/aSrtq9z\n\t18+qoZyZpAdOnjETPl0U1bqzWbjnlgUQHm4i","X-Google-Smtp-Source":"ABdhPJzUjEjHhleoU2qVdQkc39NBbZyNDutO9uT2yppDjenXoia9UuqJ1ZlCUnEqEtkUr64YcCvDgw==","X-Received":"by 2002:a63:383:: with SMTP id\n\t125mr16254953pgd.208.1626546551420; \n\tSat, 17 Jul 2021 11:29:11 -0700 (PDT)","From":"Vedant Paranjape ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 17 Jul 2021 23:58:50 +0530","Message-Id":"<20210717182850.737833-1-vedantparanjape160201@gmail.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1] gstreamer: Store group_id in\n\tGstLibcameraSrcState","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Vedant Paranjape ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch adds group_id in GstLibcameraSrcState, since group_id is\nsomething which should be same for all the pads, it can be reused\nlater.\n\nSigned-off-by: Vedant Paranjape \n---\n src/gstreamer/gstlibcamerasrc.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex ea53c2b5..ad3c692f 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -113,6 +113,7 @@ struct GstLibcameraSrcState {\n \tstd::unique_ptr config_;\n \tstd::vector srcpads_;\n \tstd::queue> requests_;\n+\tguint group_id_;\n \n \tvoid requestCompleted(Request *request);\n };\n@@ -360,7 +361,9 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \n \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n \n-\tguint group_id = gst_util_group_id_next();\n+\tif (state->group_id_ == 0) {\n+\t\tguint group_id = gst_util_group_id_next();\n+\t}\n \tgint stream_id_num = 0;\n \tStreamRoles roles;\n \tfor (GstPad *srcpad : state->srcpads_) {\n@@ -636,6 +639,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n \n \tstate->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n \tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n+\tstate->group_id_ = 0;\n \n \t/* C-style friend. */\n \tstate->src_ = self;\n","prefixes":["libcamera-devel","v1"]}