{"id":13032,"url":"https://patchwork.libcamera.org/api/1.1/patches/13032/?format=json","web_url":"https://patchwork.libcamera.org/patch/13032/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210716151642.500178-1-kieran.bingham@ideasonboard.com>","date":"2021-07-16T15:16:42","name":"[libcamera-devel,RFC] clang-format: Regroup sort orders","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a7c22ec82cfecf0bf61b3b33522e4ac3ee0b36a7","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13032/mbox/","series":[{"id":2247,"url":"https://patchwork.libcamera.org/api/1.1/series/2247/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2247","date":"2021-07-16T15:16:42","name":"[libcamera-devel,RFC] clang-format: Regroup sort orders","version":1,"mbox":"https://patchwork.libcamera.org/series/2247/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13032/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13032/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A906C3226\n\tfor ;\n\tFri, 16 Jul 2021 15:16:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8059268539;\n\tFri, 16 Jul 2021 17:16:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 774D768521\n\tfor ;\n\tFri, 16 Jul 2021 17:16:46 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EBC0B3F0;\n\tFri, 16 Jul 2021 17:16:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y+MCUd2T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626448606;\n\tbh=ujQ1k2un4HI92ZHixSJ7ewnnFuJP22e+1/InVc5famU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Y+MCUd2T4OfPz6MPKRUGT27GzhaCA1OEmAUvuHiDuy4oh6R6IeujXo19sncc5ZVj4\n\tyTd8wM/oZ83tv9iqB2RaL/G3brGThMTUJynKoO8pgnfIzy/GijYzyMo/Af1D/PSlPr\n\tqkX+jmsoiDqEPM/i6Syx/gXhLLOcMS5idFZYoFT4=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 16 Jul 2021 16:16:42 +0100","Message-Id":"<20210716151642.500178-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH] clang-format: Regroup sort orders","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Utilise the clang-format header sort to provide a regex based pattern\nmatch for our header inclusion coding style.\n\nSigned-off-by: Kieran Bingham \n---\nI used this mostly during the libcamera-base split, but it's worth\nconsidering and perhaps adapting to see if it helps in general.\n\nMay still need some tweaking and adjustments - but here's the initial\nversion for anyone who wants to try it or even for us to integrate and\nupdate as we identify any more cases or corners...\n\n .clang-format | 37 ++++++++++++++++++++++++++++++++++---\n 1 file changed, 34 insertions(+), 3 deletions(-)","diff":"diff --git a/.clang-format b/.clang-format\nindex 3a8a896e373d..5ecba901db15 100644\n--- a/.clang-format\n+++ b/.clang-format\n@@ -66,10 +66,41 @@ ExperimentalAutoDetectBinPacking: false\n FixNamespaceComments: true\n ForEachMacros:\n - 'udev_list_entry_foreach'\n-IncludeBlocks: Preserve\n+SortIncludes: true\n+IncludeBlocks: Regroup\n IncludeCategories:\n- - Regex: '.*'\n- Priority: 1\n+ # Headers in <> with or without extension. (system libraries)\n+ - Regex: '<([A-Za-z0-9\\-_])+.h>'\n+ Priority: 1 \n+ - Regex: ''\n+ Priority: 1\n+ # Linux headers, as a second group/subset of system headers\n+ - Regex: ''\n+ Priority: 2\n+ # C++ library includes (no .h)\n+ - Regex: '<([A-Za-z0-9\\-_])+>'\n+ Priority: 3\n+ # Headers for Base support\n+ - Regex: ''\n+ Priority: 4\n+ - Regex: ''\n+ Priority: 5\n+ # Headers for libcamera, which are not in a subdir (i.e. ipa/,internal/)\n+ - Regex: ''\n+ Priority: 6\n+ # IPA Interfaces\n+ - Regex: ''\n+ Priority: 7\n+ # libcamera Internal headers in \"\" \n+ - Regex: '\"libcamera/internal/.*\\.h\"'\n+ Priority: 8\n+ # local modular includes\n+ - Regex: '\".*/.*\\.h\"'\n+ Priority: 9\n+ # Other local headers \"\" with extension.\n+ - Regex: '\"([A-Za-z0-9.\\/-_])+\"'\n+ Priority: 10\n+\n IncludeIsMainRegex: '(_test)?$'\n IndentCaseLabels: false\n IndentPPDirectives: None\n","prefixes":["libcamera-devel","RFC"]}