{"id":13031,"url":"https://patchwork.libcamera.org/api/1.1/patches/13031/?format=json","web_url":"https://patchwork.libcamera.org/patch/13031/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210716143215.67454-3-jacopo@jmondi.org>","date":"2021-07-16T14:32:15","name":"[libcamera-devel,2/2] ipa: ipu3: Tidy-up includes","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2ef78543fc8e4b59255e27444f031af3f15cf2ab","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13031/mbox/","series":[{"id":2246,"url":"https://patchwork.libcamera.org/api/1.1/series/2246/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2246","date":"2021-07-16T14:32:13","name":"libcamera: Initialize controls in the IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/2246/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13031/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13031/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1A7EC322A\n\tfor ;\n\tFri, 16 Jul 2021 14:31:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 06C3C68542;\n\tFri, 16 Jul 2021 16:31:35 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37C8368536\n\tfor ;\n\tFri, 16 Jul 2021 16:31:33 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id AC13624000C;\n\tFri, 16 Jul 2021 14:31:32 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 16 Jul 2021 16:32:15 +0200","Message-Id":"<20210716143215.67454-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210716143215.67454-1-jacopo@jmondi.org>","References":"<20210716143215.67454-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] ipa: ipu3: Tidy-up includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Tidy-up a bit the inclusions directive in the IPU3 IPA module.\n\nIn detail:\n- ipu3.cpp is missing inclusions for:\n std::abs from \n std::map from \n std::min/max from \n std::numeric_limits from \n std::unique_ptr from \n std::vector from \n\n and does not require \n\n- ipu3_agc has two not used inclusions in the header file and one the cpp file\n and is missing for std::literals::chrono_literals\n\n- ipu3_awb is missing for std::sort and does not use\n or \n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/ipu3/ipu3.cpp | 7 ++++++-\n src/ipa/ipu3/ipu3_agc.cpp | 2 +-\n src/ipa/ipu3/ipu3_agc.h | 3 ---\n src/ipa/ipu3/ipu3_awb.cpp | 3 +--\n 4 files changed, 8 insertions(+), 7 deletions(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex d3c69bc07bd0..dc22acd4fd08 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -5,10 +5,15 @@\n * ipu3.cpp - IPU3 Image Processing Algorithms\n */\n \n+#include \n #include \n+#include \n+#include \n+#include \n+#include \n #include \n-#include \n #include \n+#include \n \n #include \n #include \ndiff --git a/src/ipa/ipu3/ipu3_agc.cpp b/src/ipa/ipu3/ipu3_agc.cpp\nindex 6253ab94cff1..408eb849b428 100644\n--- a/src/ipa/ipu3/ipu3_agc.cpp\n+++ b/src/ipa/ipu3/ipu3_agc.cpp\n@@ -8,8 +8,8 @@\n #include \"ipu3_agc.h\"\n \n #include \n+#include \n #include \n-#include \n \n #include \n \ndiff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h\nindex 3deca3ae6933..9f3d4257d945 100644\n--- a/src/ipa/ipu3/ipu3_agc.h\n+++ b/src/ipa/ipu3/ipu3_agc.h\n@@ -7,9 +7,6 @@\n #ifndef __LIBCAMERA_IPU3_AGC_H__\n #define __LIBCAMERA_IPU3_AGC_H__\n \n-#include \n-#include \n-\n #include \n \n #include \ndiff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\nindex 9b409c8ffad9..4bb321b377a2 100644\n--- a/src/ipa/ipu3/ipu3_awb.cpp\n+++ b/src/ipa/ipu3/ipu3_awb.cpp\n@@ -6,9 +6,8 @@\n */\n #include \"ipu3_awb.h\"\n \n+#include \n #include \n-#include \n-#include \n \n #include \n \n","prefixes":["libcamera-devel","2/2"]}