{"id":130,"url":"https://patchwork.libcamera.org/api/1.1/patches/130/?format=json","web_url":"https://patchwork.libcamera.org/patch/130/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190102110016.5489-1-jacopo@jmondi.org>","date":"2019-01-02T11:00:15","name":"[libcamera-devel,1/2] libcamera: media_device: Tiny valid() documentation improvement","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"433188b14dfc69f10fca1b684ecd071b871e19c3","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/130/mbox/","series":[{"id":48,"url":"https://patchwork.libcamera.org/api/1.1/series/48/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=48","date":"2019-01-02T11:00:15","name":"[libcamera-devel,1/2] libcamera: media_device: Tiny valid() documentation improvement","version":1,"mbox":"https://patchwork.libcamera.org/series/48/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/130/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/130/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D72CD60B2F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  2 Jan 2019 12:00:19 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 99BF760016;\n\tWed,  2 Jan 2019 11:00:18 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed,  2 Jan 2019 12:00:15 +0100","Message-Id":"<20190102110016.5489-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] libcamera: media_device: Tiny valid()\n\tdocumentation improvement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 02 Jan 2019 11:00:20 -0000"},"content":"Mention in the valid() method documentation, that a media graph has to\nbe populated to be valid.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/media_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.20.1","diff":"diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\nindex 1bd4f43..9fbc5a7 100644\n--- a/src/libcamera/media_device.cpp\n+++ b/src/libcamera/media_device.cpp\n@@ -216,7 +216,7 @@ int MediaDevice::populate()\n\n /**\n  * \\fn MediaDevice::valid()\n- * \\brief Query whether the media graph is valid\n+ * \\brief Query whether the media graph has been populated and is valid\n  * \\return true if the media graph is valid, false otherwise\n  */\n\n","prefixes":["libcamera-devel","1/2"]}