{"id":12967,"url":"https://patchwork.libcamera.org/api/1.1/patches/12967/?format=json","web_url":"https://patchwork.libcamera.org/patch/12967/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210715181522.273606-1-vedantparanjape160201@gmail.com>","date":"2021-07-15T18:15:21","name":"[libcamera-devel,v2,1/2] Fixes: 4fd6bb33 (\"libcamera: Add support for XRGB8888 and XBGR8888\")","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c716ad04f873997b57a2fef177f3f4c678e78b98","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/1.1/people/85/?format=json","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12967/mbox/","series":[{"id":2240,"url":"https://patchwork.libcamera.org/api/1.1/series/2240/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2240","date":"2021-07-15T18:15:21","name":"[libcamera-devel,v2,1/2] Fixes: 4fd6bb33 (\"libcamera: Add support for XRGB8888 and XBGR8888\")","version":2,"mbox":"https://patchwork.libcamera.org/series/2240/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12967/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12967/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0621EC3225\n\tfor ;\n\tThu, 15 Jul 2021 18:15:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4581D6852A;\n\tThu, 15 Jul 2021 20:15:50 +0200 (CEST)","from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com\n\t[IPv6:2607:f8b0:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56A6C6059F\n\tfor ;\n\tThu, 15 Jul 2021 20:15:48 +0200 (CEST)","by mail-pf1-x42f.google.com with SMTP id a127so6231781pfa.10\n\tfor ;\n\tThu, 15 Jul 2021 11:15:48 -0700 (PDT)","from localhost.localdomain ([1.186.167.37])\n\tby smtp.googlemail.com with ESMTPSA id\n\tb3sm7358293pfi.179.2021.07.15.11.15.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Jul 2021 11:15:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"cOGigy2f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=SYfOqql/X7mpZA5XQyiXNpSfKtZrj8HFScSnM6oKiGk=;\n\tb=cOGigy2fAbCBjLAKut90unKDx+d7hk/+HUyreuGUb1wfsfKb7m5oEQTWge9weouRGI\n\tVTwN4BFwLjeCP7GKDH4BiBA4h7tqmW81pABEIM/qmLCA9s+RiV5HyksU5dbiIhSAx72P\n\t3KhMZEPNeULlxyA3wB71PNcVp9ll3azA+Mx9vJ0bts8FN21+xLXRUBLnUDmuHxRGX6dV\n\t6w+IY1xHVnAJ3jKH1gdlbYovP/1CVas1GCwggqXRaF/i98zp4XlvFVtmmPf3E6eLL15R\n\t8yiM2etVJIp/3H1lUMnqy0KBm2/fcooPz0T0xCgzMKo/DIGos7NezEgX387Pd6rB4ewO\n\tichA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=SYfOqql/X7mpZA5XQyiXNpSfKtZrj8HFScSnM6oKiGk=;\n\tb=lMl9W0+WlknNBcRyW67ZEJxyAPgY105hmKbQhvwjFNoHSVVU7g9yt+NJGxDPiDH1Jt\n\tMbmmaksjHzF5KSqirOGw5BydniUyMFhzAWszyD/XV4R+2xC/i2JeZlOmQktp/1/yi2hL\n\tHfqoyNSZAQl5qFL9s+pkj4mtjCBtxZhZauOgCACIWml4nqBkcB4PAf0ufQcXYhZvoe2S\n\tB6NzKf3woG9U04gaDTqyxVT0VxvQZqjHRHLWhtwMvSxxNt6zhE7OqtZellt2Z1iavMpv\n\ttfFqF6/1p585cq3V7+y90IbqDy360JGL4lewlwJ/q6qmtpeSWYnSl7VbIAPAjzi82GP4\n\tEFbQ==","X-Gm-Message-State":"AOAM532az75AiRh0Pe10BEvYHsgt8fhU5rDyCDkUlndHE8PlKtfTqkIY\n\tB6yc6kKadXDMuERnZG7Rl8WbtnI1lIFRuivI2e0=","X-Google-Smtp-Source":"ABdhPJyBVMevx+yZla0Bv079wJ6SGCuYRSdCXeitQTmQTqnZ67rLvSvfH5QWFjTIvuV7ccy5f3WKew==","X-Received":"by 2002:a05:6a00:158e:b029:32b:9de5:a198 with SMTP id\n\tu14-20020a056a00158eb029032b9de5a198mr6019200pfk.3.1626372946282; \n\tThu, 15 Jul 2021 11:15:46 -0700 (PDT)","From":"Vedant Paranjape ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 15 Jul 2021 23:45:21 +0530","Message-Id":"<20210715181522.273606-1-vedantparanjape160201@gmail.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/2] Fixes: 4fd6bb33 (\"libcamera: Add\n\tsupport for XRGB8888 and XBGR8888\")","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Vedant Paranjape ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch fixes V4L2 pixel format for formats::XBGR8888 by updating\nthe existing matching to V4L2_PIX_FMT_RGBX32\n\nSigned-off-by: Vedant Paranjape \nReviewed-by: Paul Elder \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/formats.cpp | 2 +-\n src/libcamera/v4l2_pixelformat.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 59a34853..578ac4af 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -198,7 +198,7 @@ const std::map pixelFormatInfo{\n \t{ formats::XBGR8888, {\n \t\t.name = \"XBGR8888\",\n \t\t.format = formats::XBGR8888,\n-\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n \t\t.bitsPerPixel = 32,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n \t\t.packed = false,\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 87d728fe..59a01e02 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -52,7 +52,7 @@ const std::map vpf2pf{\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n-\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::XBGR8888 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32), formats::XBGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), formats::BGRA8888 },\n","prefixes":["libcamera-devel","v2","1/2"]}