{"id":12957,"url":"https://patchwork.libcamera.org/api/1.1/patches/12957/?format=json","web_url":"https://patchwork.libcamera.org/patch/12957/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210715101315.199703-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-07-15T10:13:15","name":"[libcamera-devel,v2] libipa: Add CameraSensorHelper for OV13858","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9d6110e9e57595aa0dc8cacb99e3e218af8636e9","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12957/mbox/","series":[{"id":2233,"url":"https://patchwork.libcamera.org/api/1.1/series/2233/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2233","date":"2021-07-15T10:13:15","name":"[libcamera-devel,v2] libipa: Add CameraSensorHelper for OV13858","version":2,"mbox":"https://patchwork.libcamera.org/series/2233/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12957/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12957/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B61BC3226\n\tfor ;\n\tThu, 15 Jul 2021 10:13:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F4D368525;\n\tThu, 15 Jul 2021 12:13:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DA7D6059F\n\tfor ;\n\tThu, 15 Jul 2021 12:13:19 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:fab7:64ae:4173:b5e8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC29B340;\n\tThu, 15 Jul 2021 12:13:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FUwlHe4R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626343998;\n\tbh=ccez79KUQgikbWV9j5/qQF8dYFROintQdId3CHBy/aw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FUwlHe4ROuNYlcIEOvp49RHTtbV8sSiz3Wz2tJINf6dWVS3pckFaiLVIKoqkZ5Ipd\n\t2T2sE9rZ3wDnmj/1irKCVoy2f7ktAsIBRG80Al/azB4iN8nSAB88rtuEu3dtLB6lkw\n\tm7parBxoifaL86s14NNF/Elti8HrV2191UCPcMaM=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 15 Jul 2021 12:13:15 +0200","Message-Id":"<20210715101315.199703-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tOV13858","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Extend the CameraSensorHelper factory with support for an\nOV13858 sensor as found in the Soraka Chromebook.\n\nThe datasheet states that low 7 bits are fraction bits, so the gain is\ncalculated as gainCode=128*gain.\nAccording to the formula, it means m0=1 and c1=128.\nm1 then has to be 0, and c0=0.\n\nSigned-off-by: Kieran Bingham \nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 84d8ccf7..17e4f0b2 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -315,6 +315,16 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n \n+class CameraSensorHelperOv13858 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperOv13858()\n+\t{\n+\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n+\n #endif /* __DOXYGEN__ */\n \n } /* namespace ipa */\n","prefixes":["libcamera-devel","v2"]}