{"id":12935,"url":"https://patchwork.libcamera.org/api/1.1/patches/12935/?format=json","web_url":"https://patchwork.libcamera.org/patch/12935/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210712215645.30478-23-laurent.pinchart@ideasonboard.com>","date":"2021-07-12T21:56:37","name":"[libcamera-devel,v2,22/30] cam: Make CamApp::cameraName() static","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d13f2866229a76dd60cccca28f6fa13fac1a9f61","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12935/mbox/","series":[{"id":2229,"url":"https://patchwork.libcamera.org/api/1.1/series/2229/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2229","date":"2021-07-12T21:56:15","name":"Multi-camera support in the cam application","version":2,"mbox":"https://patchwork.libcamera.org/series/2229/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12935/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12935/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9C9EC3229\n\tfor ;\n\tMon, 12 Jul 2021 21:57:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 710DC68542;\n\tMon, 12 Jul 2021 23:57:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A96968525\n\tfor ;\n\tMon, 12 Jul 2021 23:57:43 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B98733F1\n\tfor ;\n\tMon, 12 Jul 2021 23:57:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IO9youMX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626127063;\n\tbh=jOy4SyKjUDyf+//EBxL2A6r7aABK3WzCl6iZMitMA/w=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=IO9youMXvOFdfu3D5BUpnxQKo1jC0e+IRbjUB8xf3iOqThn318/pHo8iZAEOoQLan\n\tDz0M+N+TmRL7iZEpkU45IrpJFZlrLaUrOqHxVD+L9A6uQYSk+ne3+oAUFuKXf+lStV\n\tLn/KemZ3kXhtRc5X4i58vv7C0vXIzyARdBKumKHM=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Jul 2021 00:56:37 +0300","Message-Id":"<20210712215645.30478-23-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","References":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 22/30] cam: Make CamApp::cameraName()\n\tstatic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CamApp::cameraName() doesn't need to access any member of the CamApp\nclass. Make it static. While at it, drop an unneeded const from the\nreturn value.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/cam/main.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 19ed9837cf4f..03e62f305f24 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -44,7 +44,7 @@ private:\n \tint infoConfiguration();\n \tint run();\n \n-\tstd::string const cameraName(const Camera *camera);\n+\tstatic std::string cameraName(const Camera *camera);\n \n \tstatic CamApp *app_;\n \tOptionsParser::Options options_;\n@@ -319,7 +319,7 @@ int CamApp::run()\n \treturn 0;\n }\n \n-std::string const CamApp::cameraName(const Camera *camera)\n+std::string CamApp::cameraName(const Camera *camera)\n {\n \tconst ControlList &props = camera->properties();\n \tbool addModel = true;\n","prefixes":["libcamera-devel","v2","22/30"]}