{"id":12898,"url":"https://patchwork.libcamera.org/api/1.1/patches/12898/?format=json","web_url":"https://patchwork.libcamera.org/patch/12898/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210711231547.19664-2-laurent.pinchart@ideasonboard.com>","date":"2021-07-11T23:15:45","name":"[libcamera-devel,1/3] libcamera: ipa_manager: Fix IPA module min/max version check","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4c01917d06eac91803f416badf6b026f726643c4","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12898/mbox/","series":[{"id":2226,"url":"https://patchwork.libcamera.org/api/1.1/series/2226/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2226","date":"2021-07-11T23:15:44","name":"libcamera: ipa_manager: Fix, cleanup, and allow forcing isolation","version":1,"mbox":"https://patchwork.libcamera.org/series/2226/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12898/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12898/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 240E5BD794\n\tfor ;\n\tSun, 11 Jul 2021 23:16:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01C9268532;\n\tMon, 12 Jul 2021 01:16:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CC5A68521\n\tfor ;\n\tMon, 12 Jul 2021 01:16:37 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A0C6255\n\tfor ;\n\tMon, 12 Jul 2021 01:16:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sEvUOinP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626045397;\n\tbh=AKBanrAdVydDPTr/wUG2A8XjnWG996WDcV1XgyeSvSw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=sEvUOinP4vQEDpqy9n8+xJ+ktYWZ3SmI/MaiwbZ5T0cPmiSBvikplfXSBpTH0YFsx\n\t2iN5nxU2WwXywp7sJW+/wcqWZ0+tVhLZ6mlrL1e7TN2j6HO077FMS6mRiPzp0iumG9\n\tYZJnMDWMk9oN6AQwNgJ3YfiRYr2vA0vRs5kMw68s=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 12 Jul 2021 02:15:45 +0300","Message-Id":"<20210711231547.19664-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210711231547.19664-1-laurent.pinchart@ideasonboard.com>","References":"<20210711231547.19664-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/3] libcamera: ipa_manager: Fix IPA\n\tmodule min/max version check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPAManager::createIPA() function has its minVersion and maxVersion\nparameters inverted. This doesn't cause any issue at the moment as both\nthe minimum and maximum version are set to 1 by all callers, but it's\nstill a bug. Fix it.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/ipa_manager.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\nindex 34224e330da7..42201839901b 100644\n--- a/include/libcamera/internal/ipa_manager.h\n+++ b/include/libcamera/internal/ipa_manager.h\n@@ -31,8 +31,8 @@ public:\n \n \ttemplate\n \tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n-\t\t\t\t\t uint32_t maxVersion,\n-\t\t\t\t\t uint32_t minVersion)\n+\t\t\t\t\t uint32_t minVersion,\n+\t\t\t\t\t uint32_t maxVersion)\n \t{\n \t\tIPAModule *m = nullptr;\n \n","prefixes":["libcamera-devel","1/3"]}