{"id":12881,"url":"https://patchwork.libcamera.org/api/1.1/patches/12881/?format=json","web_url":"https://patchwork.libcamera.org/patch/12881/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210709114736.875760-1-umang.jain@ideasonboard.com>","date":"2021-07-09T11:47:35","name":"[libcamera-devel,1/2] libcamera: v4l2_videodevice: Correctly populate V4L2BufferCache cache","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"57a7bfd036485b6f3dcb9c9c60ee995d276a70e6","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12881/mbox/","series":[{"id":2222,"url":"https://patchwork.libcamera.org/api/1.1/series/2222/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2222","date":"2021-07-09T11:47:35","name":"[libcamera-devel,1/2] libcamera: v4l2_videodevice: Correctly populate V4L2BufferCache cache","version":1,"mbox":"https://patchwork.libcamera.org/series/2222/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12881/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12881/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD2F0BD794\n\tfor ;\n\tFri, 9 Jul 2021 11:47:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 565506851B;\n\tFri, 9 Jul 2021 13:47:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F8C9605AC\n\tfor ;\n\tFri, 9 Jul 2021 13:47:52 +0200 (CEST)","from perceval.ideasonboard.com (unknown\n\t[IPv6:2405:204:8084:161d:f4be:7125:3161:2a88])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AE165E7;\n\tFri, 9 Jul 2021 13:47:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pr52KtmF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625831271;\n\tbh=fnn6lGVKvm3aK7GoZx22Fz7to/hbLivZFr9ppoxjRgs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=pr52KtmFPg5saDe3I169CssG/FSig7Ed0rQDwh5az+iwCU/aB/QSDEzuhcMCX6Je3\n\tLnYfxd2QD2GUR6Z2g8KRZDNzGPHBtqRB3dDSiuQ/fxZDXalk9kYWNFD2g7xj4+dlNN\n\t1Z0VOhqjgEsVLTu6I6xtJHrum0ahx4SpM2ofJsiI=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 9 Jul 2021 17:17:35 +0530","Message-Id":"<20210709114736.875760-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] libcamera: v4l2_videodevice:\n\tCorrectly populate V4L2BufferCache cache","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Populating of the cache in V4L2BufferCache's constructor is incorrect.\nThe cache_ in V4L2BufferCache is a vector of struct Entry, whose\nconstructor takes the form:\n\n\tEntry(bool free, uint64_t lastUsed, const FrameBuffer &buffer)\n\nPassing a FrameBuffer::Plane vector via buffer->planes() is\nincorrect. Rectify by passing in a Framebuffer reference.\n\nSigned-off-by: Umang Jain \n---\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 3d2d99b4..da2af6a1 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -183,7 +183,7 @@ V4L2BufferCache::V4L2BufferCache(const std::vector>\n \tfor (const std::unique_ptr &buffer : buffers)\n \t\tcache_.emplace_back(true,\n \t\t\t\t lastUsedCounter_.fetch_add(1, std::memory_order_acq_rel),\n-\t\t\t\t buffer->planes());\n+\t\t\t\t *buffer.get());\n }\n \n V4L2BufferCache::~V4L2BufferCache()\n","prefixes":["libcamera-devel","1/2"]}