{"id":12872,"url":"https://patchwork.libcamera.org/api/1.1/patches/12872/?format=json","web_url":"https://patchwork.libcamera.org/patch/12872/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210709095638.2801713-1-naush@raspberrypi.com>","date":"2021-07-09T09:56:31","name":"[libcamera-devel,v5,1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9fc4c198c499d9ada202e2973a56da03a2b14301","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12872/mbox/","series":[{"id":2220,"url":"https://patchwork.libcamera.org/api/1.1/series/2220/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2220","date":"2021-07-09T09:56:31","name":"[libcamera-devel,v5,1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments","version":5,"mbox":"https://patchwork.libcamera.org/series/2220/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12872/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12872/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3B6ABD794\n\tfor ;\n\tFri, 9 Jul 2021 09:56:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2778468524;\n\tFri, 9 Jul 2021 11:56:51 +0200 (CEST)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 776B9684F3\n\tfor ;\n\tFri, 9 Jul 2021 11:56:49 +0200 (CEST)","by mail-wr1-x436.google.com with SMTP id m2so340643wrq.2\n\tfor ;\n\tFri, 09 Jul 2021 02:56:49 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:35c2:26d3:e217:4410])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm1599014wrw.46.2021.07.09.02.56.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 09 Jul 2021 02:56:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"NgHRY8Ki\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=D3oFpFZ1p9wALh8EJbaFVtp6PZMGVEaHidSzqojaPWk=;\n\tb=NgHRY8KitMyYbpbIi8XJF8LYVbTwoKH4gJRZT6+X4QSc8hYncc7nbbiD0ywhX7jhvc\n\tNBS/cBaDP+rPGpM9fEJve8awsKD5p3Kq5flpNnxjoNN/YON3M+tg495OfYTRnLccMVCZ\n\tQEWDOz8Lc7beLsOIppD2vGbSHSHPNDmJuTNkFBoxjXVSUH3dUpODEdDNm6pLJnmtHOoC\n\tiSxq1wdoTmF3FRl2Qcd80j5IgoEASMpdG6vHYFOf7TvZdo8kC94iRPubUNTYqcbW2x3B\n\tbarY32VLQ1dczRLTeVKNBJGuxt9WFNxyHw8aHj3MP7MhHpzLnSCySIPtyuEZ8kCWRRar\n\tXoAA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=D3oFpFZ1p9wALh8EJbaFVtp6PZMGVEaHidSzqojaPWk=;\n\tb=PYNxUk9qFq6V3DzM4GWO8pEj8gnPkJstgU0wHlWQYZ1erQ2s2pOXcDznDXd22vuEh4\n\tNbpwqVOqkfqnW36jiN4he8n7JvmJDr7vLZEpeZ+4qC4C/vZkR/aGDRFDoiHoCmI0/YBk\n\thKMuHWaevvhcgvYyjHLvx4KIdhS329NvXWZQMxtnMxn/m2Xj5Or8OQvaP4qrZOkPDeoL\n\tqxLwEFZ71oY9KqfDvwT35AnvuP1sPEBpRqNit0W8aLmW9dbVwRzTjmKifIBxGTOVW9f+\n\tNcYcp7WIUWX/Iy4NtfSnO4QLNfeV1bsUvB0ED1Ve/ENcrk8/0/IXu9nooRbFekjBbHMg\n\tuOBA==","X-Gm-Message-State":"AOAM530CYly9/NXC6/t8GhHXxftNeajFeAYQezITnsPoBmORJCOnGdQq\n\tsoRv1AkdsD3kZOIShHcx1YuH2cdplWKjjw==","X-Google-Smtp-Source":"ABdhPJxWY0jlPQD5zdnL4RkHLyCj+Atst9N3qvHxsHuXxPgqYravg0NludQ7xMyfKAJ5dEaZk77y2w==","X-Received":"by 2002:a5d:64e4:: with SMTP id\n\tg4mr33690572wri.377.1625824608762; \n\tFri, 09 Jul 2021 02:56:48 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 9 Jul 2021 10:56:31 +0100","Message-Id":"<20210709095638.2801713-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 1/8] ipa: raspberrypi: Make\n\tdevice_status.h C++ only header, and update comments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This header file is no longer C compatible, so remove the extern \"C\"\ndeclaration.\n\nReplace C++ style comments with C style based on libcamera guidelines.\n\nThere are no functional changes in this commit.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \n---\n .../raspberrypi/controller/device_status.h | 24 +++++++------------\n 1 file changed, 9 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\nindex f74235248b12..733378dbfa27 100644\n--- a/src/ipa/raspberrypi/controller/device_status.h\n+++ b/src/ipa/raspberrypi/controller/device_status.h\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: BSD-2-Clause */\n /*\n- * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n+ * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n *\n * device_status.h - device (image sensor) status\n */\n@@ -8,25 +8,19 @@\n \n #include \n \n-// Definition of \"device metadata\" which stores things like shutter time and\n-// analogue gain that downstream control algorithms will want to know.\n-\n-#ifdef __cplusplus\n-extern \"C\" {\n-#endif\n+/*\n+ * Definition of \"device metadata\" which stores things like shutter time and\n+ * analogue gain that downstream control algorithms will want to know.\n+ */\n \n struct DeviceStatus {\n-\t// time shutter is open\n+\t/* time shutter is open */\n \tlibcamera::utils::Duration shutter_speed;\n \tdouble analogue_gain;\n-\t// 1.0/distance-in-metres, or 0 if unknown\n+\t/* 1.0/distance-in-metres, or 0 if unknown */\n \tdouble lens_position;\n-\t// 1/f so that brightness quadruples when this doubles, or 0 if unknown\n+\t/* 1/f so that brightness quadruples when this doubles, or 0 if unknown */\n \tdouble aperture;\n-\t// proportional to brightness with 0 = no flash, 1 = maximum flash\n+\t/* proportional to brightness with 0 = no flash, 1 = maximum flash */\n \tdouble flash_intensity;\n };\n-\n-#ifdef __cplusplus\n-}\n-#endif\n","prefixes":["libcamera-devel","v5","1/8"]}