{"id":12845,"url":"https://patchwork.libcamera.org/api/1.1/patches/12845/?format=json","web_url":"https://patchwork.libcamera.org/patch/12845/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210707094815.1500917-2-naush@raspberrypi.com>","date":"2021-07-07T09:48:08","name":"[libcamera-devel,v4,1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9fc4c198c499d9ada202e2973a56da03a2b14301","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12845/mbox/","series":[{"id":2214,"url":"https://patchwork.libcamera.org/api/1.1/series/2214/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2214","date":"2021-07-07T09:48:07","name":"Raspberry Pi: Enable imx477 long exposure modes","version":4,"mbox":"https://patchwork.libcamera.org/series/2214/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12845/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12845/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40C34C3224\n\tfor ;\n\tWed, 7 Jul 2021 09:48:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 676C06851F;\n\tWed, 7 Jul 2021 11:48:20 +0200 (CEST)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E799F68506\n\tfor ;\n\tWed, 7 Jul 2021 11:48:18 +0200 (CEST)","by mail-wr1-x42c.google.com with SMTP id p8so2341992wrr.1\n\tfor ;\n\tWed, 07 Jul 2021 02:48:18 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:f800:302e:bf7e:a06b])\n\tby smtp.gmail.com with ESMTPSA id\n\tr16sm23377836wrx.63.2021.07.07.02.48.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Jul 2021 02:48:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Oyzw3sYx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=D3oFpFZ1p9wALh8EJbaFVtp6PZMGVEaHidSzqojaPWk=;\n\tb=Oyzw3sYxgKbdok7MiAIUVoEnHh+mZxYtYeEdu6WSSjaUL3CPFO/g5VzDd4SvTMQKnn\n\tA670L463l9f+1Oc0/fzO+IE+Bgd1vMKNAYJc8st6S1WA2bLvutM4ehpAXZlDl9AAQEfv\n\tUPiM3ze1O7QwW0zN35H9okldotW+2Vltxd8jFsA/91qdw589k4IFBkynTHDOhD2PbD1K\n\tjgaL3Sf5lP7nkibHptWEYJS1gbynLmOimkgKv+z9xfgpsZmf0vg8iKzE7xJy7zG/3Ily\n\tq5G+jj8O7jKawdQjGe+3xhxxxuZidDBg7/LcUfKSkUC3aAnJGkipuBh5u2hWsUU1ky1E\n\tlNkw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=D3oFpFZ1p9wALh8EJbaFVtp6PZMGVEaHidSzqojaPWk=;\n\tb=VaQbTEzd254iEdPyV07AfVbOA3khy9Rvg8Uoy98MrBfWWGEuOk5OI8IK/HUgHS61ks\n\tkk3eN9yXxhHgKRAUCu4Umb9fHJtkzoh5GHnh1Ed6+P0DrVWmOjffNJB45jJcUshINUAl\n\tUQnCZq8FdRPlSFVxeHhVX6rjf5HSjmnuUVVjAM8YjdCFFph+8O23LEl3TBs5Gjp+0xnW\n\t/q1zsYW92A3Ms4pRMLona1tv/HoXIp1cbRDaiZmGgd5Zznv5gveO+pQXp/r3v9lu81fw\n\tvSQtyE1tYG6CCV8MG1hP6a5Gi8BIs1at5yOQzOSPHpMEgSwbhXZi82LM0+540swiJyDx\n\tmTUQ==","X-Gm-Message-State":"AOAM530ro9LWZ56N2vVlZR8EY+tDEVJoj5RplvGeiPmkwHqKQkqSfbos\n\tBMCis4D0X3PtV1fj+hgMmYquWWoo9Ikqgw==","X-Google-Smtp-Source":"ABdhPJzbs6RMRuDkjYC+TR14J2NBtI2j8cwWuGE+0l6V+WLHKyCp8qFl9MQIHG657uPwPOygayRukg==","X-Received":"by 2002:adf:d232:: with SMTP id\n\tk18mr15789851wrh.35.1625651298458; \n\tWed, 07 Jul 2021 02:48:18 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 7 Jul 2021 10:48:08 +0100","Message-Id":"<20210707094815.1500917-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210707094815.1500917-1-naush@raspberrypi.com>","References":"<20210707094815.1500917-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 1/8] ipa: raspberrypi: Make\n\tdevice_status.h C++ only header, and update comments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This header file is no longer C compatible, so remove the extern \"C\"\ndeclaration.\n\nReplace C++ style comments with C style based on libcamera guidelines.\n\nThere are no functional changes in this commit.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \n---\n .../raspberrypi/controller/device_status.h | 24 +++++++------------\n 1 file changed, 9 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\nindex f74235248b12..733378dbfa27 100644\n--- a/src/ipa/raspberrypi/controller/device_status.h\n+++ b/src/ipa/raspberrypi/controller/device_status.h\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: BSD-2-Clause */\n /*\n- * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n+ * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n *\n * device_status.h - device (image sensor) status\n */\n@@ -8,25 +8,19 @@\n \n #include \n \n-// Definition of \"device metadata\" which stores things like shutter time and\n-// analogue gain that downstream control algorithms will want to know.\n-\n-#ifdef __cplusplus\n-extern \"C\" {\n-#endif\n+/*\n+ * Definition of \"device metadata\" which stores things like shutter time and\n+ * analogue gain that downstream control algorithms will want to know.\n+ */\n \n struct DeviceStatus {\n-\t// time shutter is open\n+\t/* time shutter is open */\n \tlibcamera::utils::Duration shutter_speed;\n \tdouble analogue_gain;\n-\t// 1.0/distance-in-metres, or 0 if unknown\n+\t/* 1.0/distance-in-metres, or 0 if unknown */\n \tdouble lens_position;\n-\t// 1/f so that brightness quadruples when this doubles, or 0 if unknown\n+\t/* 1/f so that brightness quadruples when this doubles, or 0 if unknown */\n \tdouble aperture;\n-\t// proportional to brightness with 0 = no flash, 1 = maximum flash\n+\t/* proportional to brightness with 0 = no flash, 1 = maximum flash */\n \tdouble flash_intensity;\n };\n-\n-#ifdef __cplusplus\n-}\n-#endif\n","prefixes":["libcamera-devel","v4","1/8"]}