{"id":12817,"url":"https://patchwork.libcamera.org/api/1.1/patches/12817/?format=json","web_url":"https://patchwork.libcamera.org/patch/12817/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210707021941.20804-5-laurent.pinchart@ideasonboard.com>","date":"2021-07-07T02:19:15","name":"[libcamera-devel,04/30] cam: options: Move OptionValue class after OptionsParser","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6e1b95da24f13bfe2df34a50d346a5217d8b398d","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12817/mbox/","series":[{"id":2213,"url":"https://patchwork.libcamera.org/api/1.1/series/2213/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2213","date":"2021-07-07T02:19:12","name":"Multi-camera support in the cam application","version":1,"mbox":"https://patchwork.libcamera.org/series/2213/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12817/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12817/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB862BD794\n\tfor ;\n\tWed, 7 Jul 2021 02:20:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FE7968518;\n\tWed, 7 Jul 2021 04:20:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01CF368506\n\tfor ;\n\tWed, 7 Jul 2021 04:20:33 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B14E2E4\n\tfor ;\n\tWed, 7 Jul 2021 04:20:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K6K9WFPa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625624432;\n\tbh=R/qMO5o5HOEtdLAGq//T6U0IGZuZS2NFt8bYoUAD6H4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=K6K9WFParKf+48TbdBKMxXuVj9rigBNdNw+rhzWfuD3/+xiA2hGvCW6KxPrpgA1i+\n\thpub9lmTbFciEBXASAO31kNoxRHGfZnIVsnyPsb986PTCItgQIiqYiTGlx+SXzvtjN\n\tW36kCE2oyU8jFB0aHT26BYWnVeJJA+q196D2lGRA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 7 Jul 2021 05:19:15 +0300","Message-Id":"<20210707021941.20804-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210707021941.20804-1-laurent.pinchart@ideasonboard.com>","References":"<20210707021941.20804-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 04/30] cam: options: Move OptionValue\n\tclass after OptionsParser","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To prepare for usage of the OptionsParser::Options class in OptionValue,\nmove the definition of the OptionValue class after OptionsParser. There\nis not functional change.\n\nSigned-off-by: Laurent Pinchart \n---\n src/cam/options.h | 54 +++++++++++++++++++++++------------------------\n 1 file changed, 27 insertions(+), 27 deletions(-)","diff":"diff --git a/src/cam/options.h b/src/cam/options.h\nindex 688fe26011f8..a3b18bb6c4ea 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -74,6 +74,33 @@ private:\n \tstd::map optionsMap_;\n };\n \n+class OptionsParser\n+{\n+public:\n+\tclass Options : public OptionsBase\n+\t{\n+\t};\n+\n+\tOptionsParser();\n+\t~OptionsParser();\n+\n+\tbool addOption(int opt, OptionType type, const char *help,\n+\t\t const char *name = nullptr,\n+\t\t OptionArgument argument = ArgumentNone,\n+\t\t const char *argumentName = nullptr, bool array = false);\n+\tbool addOption(int opt, KeyValueParser *parser, const char *help,\n+\t\t const char *name = nullptr, bool array = false);\n+\n+\tOptions parse(int argc, char *argv[]);\n+\tvoid usage();\n+\n+private:\n+\tvoid parseValueError(const Option &option);\n+\n+\tstd::list