{"id":12807,"url":"https://patchwork.libcamera.org/api/1.1/patches/12807/?format=json","web_url":"https://patchwork.libcamera.org/patch/12807/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210704233620.9145-2-laurent.pinchart@ideasonboard.com>","date":"2021-07-04T23:36:20","name":"[libcamera-devel,2/2] android: Disable copy and move for CameraDevice","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"77d29b53587a94b5ffd8a425f937fcfec98f7642","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12807/mbox/","series":[{"id":2207,"url":"https://patchwork.libcamera.org/api/1.1/series/2207/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2207","date":"2021-07-04T23:36:19","name":"[libcamera-devel,1/2] android: Disable copy and move for CameraHalManager","version":1,"mbox":"https://patchwork.libcamera.org/series/2207/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12807/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12807/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6D1EC3222\n\tfor ;\n\tSun, 4 Jul 2021 23:37:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38AAF68501;\n\tMon, 5 Jul 2021 01:37:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4E4168500\n\tfor ;\n\tMon, 5 Jul 2021 01:37:05 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55D952E4\n\tfor ;\n\tMon, 5 Jul 2021 01:37:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RhsqPtms\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625441825;\n\tbh=VCeb9YNd7oBXk5xTquBkWhgDIAkPazTo5fck7MrG0vI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=RhsqPtmspumNXkw/GIMUzx9xrvG4PijAzBrZaDJEcpCfM+T/7jTs4jytGw+CiLEcP\n\tj6f093X7Lgf78hYTKgMvOqyn1FKF7p9SurrNTv2z+roeLRgVaz0hMoyHNJwKqTAzZB\n\t4admSsjSjxGEd3MGskzeLl1z60R++PTaXbSlPwQo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 5 Jul 2021 02:36:20 +0300","Message-Id":"<20210704233620.9145-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210704233620.9145-1-laurent.pinchart@ideasonboard.com>","References":"<20210704233620.9145-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] android: Disable copy and move for\n\tCameraDevice","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instances of the CameraDevice class should never be copied or moved, as\nthey represent resources, Disable copying and moving for the class.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_device.h | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 3361918d4484..d085a27f296b 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -14,6 +14,7 @@\n \n #include \n \n+#include \n #include \n #include \n #include \n@@ -66,6 +67,8 @@ protected:\n \tstd::string logPrefix() const override;\n \n private:\n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraDevice)\n+\n \tCameraDevice(unsigned int id, std::shared_ptr camera);\n \n \tstruct Camera3RequestDescriptor {\n","prefixes":["libcamera-devel","2/2"]}