{"id":12766,"url":"https://patchwork.libcamera.org/api/1.1/patches/12766/?format=json","web_url":"https://patchwork.libcamera.org/patch/12766/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210702103800.41291-2-paul.elder@ideasonboard.com>","date":"2021-07-02T10:37:45","name":"[libcamera-devel,RFC,v3,01/16] controls: Add boolean constructor for ControlInfo","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ef97252a52a97a0153b7a1bf333438221c19a7af","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12766/mbox/","series":[{"id":2199,"url":"https://patchwork.libcamera.org/api/1.1/series/2199/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2199","date":"2021-07-02T10:37:44","name":"Preliminary FULL plumbing","version":3,"mbox":"https://patchwork.libcamera.org/series/2199/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12766/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12766/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56955C3222\n\tfor ;\n\tFri, 2 Jul 2021 10:38:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 081D5684EA;\n\tFri, 2 Jul 2021 12:38:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4400684F4\n\tfor ;\n\tFri, 2 Jul 2021 12:38:14 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 29E874AB;\n\tFri, 2 Jul 2021 12:38:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bgxVp09D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625222294;\n\tbh=z9IJjouWybFV7nry8bVO05OXCZmi4nqmm270vwxuz2g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bgxVp09D7n3EbiD1OrisfcoeaVBC/X6rBF/wm7vXj7gfO5aGEWkZw2RBET24oSps6\n\t8veV5jHJkFHQ9Ht1SQZuVNg7RjnXfEVheertu1U+CTtGq+VWrfKrfyoGl3fg7TaMZ/\n\tcTzW/td8ZTkOgSPhPoBsmWI5gSITyPK2Xbf66ifI=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Jul 2021 19:37:45 +0900","Message-Id":"<20210702103800.41291-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","References":"<20210702103800.41291-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v3 01/16] controls: Add boolean\n\tconstructor for ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It would be convenient to be able to iterate over available boolean\nvalues, for example for controls that designate if some function can be\nenabled/disabled. The current min/max/def constructor is insufficient,\nas .values() is empty, so the values cannot be easily iterated over, and\ncreating a Span of booleans does not work for the values constructor.\n\nAdd a new constructor to ControlInfo that takes a Span of booleans (to\nallow specifiying one or two available values), and a default. The\ndefault value is not optional, as it doesn't make sense to have a silent\ndefault for boolean values.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v3\n---\n include/libcamera/controls.h | 1 +\n src/libcamera/controls.cpp | 20 ++++++++++++++++++++\n 2 files changed, 21 insertions(+)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 1bc958a4..2dd147c8 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -272,6 +272,7 @@ public:\n \t\t\t const ControlValue &def = 0);\n \texplicit ControlInfo(Span values,\n \t\t\t const ControlValue &def = {});\n+\texplicit ControlInfo(Span values, bool def);\n \n \tconst ControlValue &min() const { return min_; }\n \tconst ControlValue &max() const { return max_; }\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 34317fa0..e32e22e2 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -514,6 +514,26 @@ ControlInfo::ControlInfo(Span values,\n \t\tvalues_.push_back(value);\n }\n \n+/**\n+ * \\brief Construct a ControlInfo from a list of valid boolean values\n+ * \\param[in] values The control valid boolean vaalues\n+ * \\param[in] def The control default boolean value\n+ *\n+ * Construct a ControlInfo from a list of valid boolean values. The ControlInfo\n+ * minimum and maximum values are set to the first and last members of the\n+ * values list respectively. The default value is set to \\a def.\n+ */\n+ControlInfo::ControlInfo(Span values, bool def)\n+\t: def_(def)\n+{\n+\tmin_ = values.front();\n+\tmax_ = values.back();\n+\n+\tvalues_.reserve(2);\n+\tfor (const bool &value : values)\n+\t\tvalues_.push_back(value);\n+}\n+\n /**\n * \\fn ControlInfo::min()\n * \\brief Retrieve the minimum value of the control\n","prefixes":["libcamera-devel","RFC","v3","01/16"]}