{"id":12725,"url":"https://patchwork.libcamera.org/api/1.1/patches/12725/?format=json","web_url":"https://patchwork.libcamera.org/patch/12725/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210628122324.14541-3-david.plowman@raspberrypi.com>","date":"2021-06-28T12:23:23","name":"[libcamera-devel,v4,2/3] libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2a61ab090174e2fc3baae2dd3f2bdde50d19af16","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12725/mbox/","series":[{"id":2184,"url":"https://patchwork.libcamera.org/api/1.1/series/2184/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2184","date":"2021-06-28T12:23:21","name":"Support monochrome raw sensors","version":4,"mbox":"https://patchwork.libcamera.org/series/2184/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12725/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12725/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 870EBC3220\n\tfor ;\n\tMon, 28 Jun 2021 12:23:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10087684D6;\n\tMon, 28 Jun 2021 14:23:30 +0200 (CEST)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99876684D3\n\tfor ;\n\tMon, 28 Jun 2021 14:23:27 +0200 (CEST)","by mail-wm1-x333.google.com with SMTP id\n\to33-20020a05600c5121b02901e360c98c08so11862524wms.5\n\tfor ;\n\tMon, 28 Jun 2021 05:23:27 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\ts62sm19606542wms.13.2021.06.28.05.23.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 28 Jun 2021 05:23:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"aojMhd0i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=E9nCDyDkwew2QWgv+wjfgUYgt/K9qJddnw+iPJh6jz8=;\n\tb=aojMhd0i21Fi7CHeq+qaceC+y5N6HPBE+6vHsPs9gWeBbNvok+nYSorO+HVFd0KAol\n\tS8OwglgcPBLKxoS/U2eUzhMBocguZsQbUNcOv2Kfi/K903OHTXcBPL2kmEc2xnMtVsNn\n\t7gaZdO9WSp7qSti1TkjsT6vRU7xwKexkRKulpkCr/7udCUJGirOB4f87r5IDPj6ho1q2\n\tYfH2ptjqlRnzfzh+SCWXKgEPablyVn03l4Un+udqV5vbhumNX1NKeOOxiWwRE7XHbSm5\n\trgUk4JOn779xX8+G7jSmhv2vk1tNW556rC+bKY5yUA1p7Gbo5fxPJ1hDE46W5VqLbtJv\n\tmZgA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=E9nCDyDkwew2QWgv+wjfgUYgt/K9qJddnw+iPJh6jz8=;\n\tb=WXD6ZnWjK0BReSj9/+5BTaYXwtkfuHISn85Z+I0yJL2cfHC2C+okndkjjsVm5Ry49w\n\ttS0uiixgUOeKxsWifxAAU2sj49j+ZXxDdz9JEhBv2z1hDZRpPIIOS4tAhw1VOAKRxIb3\n\tc/krXvDmU1rLZXrzA4MXeTHUUmZfq1Mr9DHv4hkl6aYTkHg5z4cdx53a1NPKqD04j4ms\n\t2Im1t4f5mrmoMHh4CUxFt+tT8qd+aV0DQMQHYxTaBLjDTZgQFlYs+NDTwNkYy9s6CD0B\n\tOma4YmLvFZBeJLKhTZwefuK6aBlJ0rnSSOw4JVGeG+z+U+v7IJyBZduq4AtkJyo5Pdf/\n\tBIoA==","X-Gm-Message-State":"AOAM531+yylGYl2NjomHdRXiKKwBs99GV8n6ceBFusGmglttGDj/MukY\n\tJMo7lOILD4yMLEGXLtii+BJOf3D+ekXhZg==","X-Google-Smtp-Source":"ABdhPJx443yqzdVg7CdNhwVIHRNPJu0ahteDp3Ba60sNd/LQujPrAQhrsNfOI9MlOKR26oYP3USXmA==","X-Received":"by 2002:a05:600c:3502:: with SMTP id\n\th2mr23683974wmq.68.1624883007121; \n\tMon, 28 Jun 2021 05:23:27 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Jun 2021 13:23:23 +0100","Message-Id":"<20210628122324.14541-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210628122324.14541-1-david.plowman@raspberrypi.com>","References":"<20210628122324.14541-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 2/3] libcamera: ipa: raspberrypi:\n\tDemote warnings about lack of AWB results","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Warnings about the lack of AWB status results are demoted to being\njust \"Debug\". With monochrome sensors becoming more common this would\notherwise overwhelm the console output, and in practice nothing is\nreally lost as it is normally very evident if AWB is failing to run.\n\nSigned-off-by: David Plowman \nReviewed-by: Naushir Patuck \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex 55e80ac7..2c95f287 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata)\n \tawb_.gain_g = 1.0;\n \tawb_.gain_b = 1.0;\n \tif (image_metadata->Get(\"awb.status\", awb_) != 0)\n-\t\tLOG(RPiAgc, Warning) << \"Agc: no AWB status found\";\n+\t\tLOG(RPiAgc, Debug) << \"Agc: no AWB status found\";\n }\n \n static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb,\ndiff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\nindex b0d24aa2..ef99c1b0 100644\n--- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n@@ -267,8 +267,8 @@ double get_ct(Metadata *metadata, double default_ct)\n \tAwbStatus awb_status;\n \tawb_status.temperature_K = default_ct; // in case nothing found\n \tif (metadata->Get(\"awb.status\", awb_status) != 0)\n-\t\tLOG(RPiAlsc, Warning) << \"no AWB results found, using \"\n-\t\t\t\t << awb_status.temperature_K;\n+\t\tLOG(RPiAlsc, Debug) << \"no AWB results found, using \"\n+\t\t\t\t << awb_status.temperature_K;\n \telse\n \t\tLOG(RPiAlsc, Debug) << \"AWB results found, using \"\n \t\t\t\t << awb_status.temperature_K;\n","prefixes":["libcamera-devel","v4","2/3"]}