{"id":1271,"url":"https://patchwork.libcamera.org/api/1.1/patches/1271/?format=json","web_url":"https://patchwork.libcamera.org/patch/1271/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190523135900.24029-3-kieran.bingham@ideasonboard.com>","date":"2019-05-23T13:58:59","name":"[libcamera-devel,v2,2/3] test: v4l2_device: Extend formats test with tryFromat()","commit_ref":null,"pull_url":null,"state":"deferred","archived":false,"hash":"4310248960a75a64ff7e9781594e38677c12c248","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/1271/mbox/","series":[{"id":322,"url":"https://patchwork.libcamera.org/api/1.1/series/322/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=322","date":"2019-05-23T13:58:57","name":"V4L2Device Try format support","version":2,"mbox":"https://patchwork.libcamera.org/series/322/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1271/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1271/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB27060DE9\n\tfor ;\n\tThu, 23 May 2019 15:59:05 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7842CB7C;\n\tThu, 23 May 2019 15:59:05 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558619945;\n\tbh=a0eycquhtYysrCMaRms7fN5KsRROLlUE7QgcgkNOKy8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=niAbE98GzyHMBRdtnmebjFM7Oce0aCWzHD499TvWfQPiGb16JJk9IGfsDeKOKcbFb\n\tx5hvx0h4IR6ZgR0utNwjRPJ9i88dFxiJwuLEETniH8DMOTDdqEkcRK0tiiimJ0P0fS\n\thUgC96g0f3pLYUN1GkCDYNChf+xHk0LkMMrb6rW4=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Thu, 23 May 2019 14:58:59 +0100","Message-Id":"<20190523135900.24029-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190523135900.24029-1-kieran.bingham@ideasonboard.com>","References":"<20190523135900.24029-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/3] test: v4l2_device: Extend formats\n\ttest with tryFromat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 23 May 2019 13:59:06 -0000"},"content":"Add a new test to verify the tryFormat() functionality updates the\nattempted format.\n\nSigned-off-by: Kieran Bingham \n---\n test/v4l2_device/formats.cpp | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)","diff":"diff --git a/test/v4l2_device/formats.cpp b/test/v4l2_device/formats.cpp\nindex 6be045ff754c..1ed9901a9e4e 100644\n--- a/test/v4l2_device/formats.cpp\n+++ b/test/v4l2_device/formats.cpp\n@@ -31,6 +31,22 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\tformat.size = { UINT_MAX, UINT_MAX };\n+\t\tret = capture_->tryFormat(&format);\n+\t\tif (ret) {\n+\t\t\tcerr << \"Failed to try format: image resolution is invalid: \"\n+\t\t\t << \"(UINT_MAX x UINT_MAX) but setFormat() should not fail.\"\n+\t\t\t << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (format.size.width == UINT_MAX ||\n+\t\t format.size.height == UINT_MAX) {\n+\t\t\tcerr << \"Failed to update image (try) format = (UINT_MAX x UINT_MAX)\"\n+\t\t\t << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\tformat.size = { UINT_MAX, UINT_MAX };\n \t\tret = capture_->setFormat(&format);\n \t\tif (ret) {\n","prefixes":["libcamera-devel","v2","2/3"]}