{"id":12708,"url":"https://patchwork.libcamera.org/api/1.1/patches/12708/?format=json","web_url":"https://patchwork.libcamera.org/patch/12708/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210625154407.1127913-1-kieran.bingham@ideasonboard.com>","date":"2021-06-25T15:44:07","name":"[libcamera-devel] media-libs/libcamera: Split out the Android camera HAL","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"868db42db2c20930bac9c9bc34cdf1ea2ed3bcb6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12708/mbox/","series":[{"id":2176,"url":"https://patchwork.libcamera.org/api/1.1/series/2176/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2176","date":"2021-06-25T15:44:07","name":"[libcamera-devel] media-libs/libcamera: Split out the Android camera HAL","version":1,"mbox":"https://patchwork.libcamera.org/series/2176/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12708/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12708/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51B95C321A\n\tfor ;\n\tFri, 25 Jun 2021 15:44:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74A4C684CF;\n\tFri, 25 Jun 2021 17:44:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 326A0684C9\n\tfor ;\n\tFri, 25 Jun 2021 17:44:11 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB6EB8B6;\n\tFri, 25 Jun 2021 17:44:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MZAX6lyr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624635850;\n\tbh=sDQw94+VSx85h760yvI7u+DanDn8QQ1Zyd9Hdh1ON0k=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=MZAX6lyrGpb0hywEJFwZc9CkFcpx0wlAHHNQafapAbb4yJQv7h3zXCEdUlJQpPggz\n\t3By7BJM1CvZPEETbbOgwI+J960btxmefDJK20hym/a7tBs/nlmSIFZ7hHv5notAjPP\n\t3jkMjhJa0P9VX3n0Ppv8Vkeej5sK7WPJSyOwnyII=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 25 Jun 2021 16:44:07 +0100","Message-Id":"<20210625154407.1127913-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] media-libs/libcamera: Split out the\n\tAndroid camera HAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The camera HAL interface has historically been linked directly into the\nlibcamera shared library.\n\nThe HAL is now built as it's own .so file, so install accordingly.\nSwitch from using dosym to making use of the cros-camera_dohal to aim\nfor consistency with other HAL installations.\n\nBUG=None\nTEST=cros deploy ${DUT} libcamera && cros_camera_service\n\nChange-Id: I0d3f02218306e10f7d73a08a1546a2b89596127b\n---\nNow that the libcamera split series is merged, this change is required\nto build libcamera on ChromeOS.\n\nFor all the chrome users out there, you will need this patch to apply to\nyour tree.\n\nThis patch has already been submitted to chrome, and can be expected to\nbe merged through those processes - but until then - here's what you'll\nneed.\n\n--\nKieran\n\n\n media-libs/libcamera/libcamera-9999.ebuild | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/media-libs/libcamera/libcamera-9999.ebuild b/media-libs/libcamera/libcamera-9999.ebuild\nindex c6b2ea63d74d..1e28d2e5c8ac 100644\n--- a/media-libs/libcamera/libcamera-9999.ebuild\n+++ b/media-libs/libcamera/libcamera-9999.ebuild\n@@ -6,7 +6,7 @@ EAPI=7\n CROS_WORKON_PROJECT=\"chromiumos/third_party/libcamera\"\n CROS_WORKON_INCREMENTAL_BUILD=\"1\"\n \n-inherit cros-workon meson\n+inherit cros-camera cros-workon meson\n \n DESCRIPTION=\"Camera support library for Linux\"\n HOMEPAGE=\"https://www.libcamera.org\"\n@@ -67,7 +67,7 @@ src_compile() {\n src_install() {\n \tmeson_src_install\n \n-\tdosym ../libcamera.so \"/usr/$(get_libdir)/camera_hal/libcamera.so\"\n+\tcros-camera_dohal \"${D}/usr/$(get_libdir)/libcamera-hal.so\" libcamera-hal.so\n \n \tdostrip -x \"/usr/$(get_libdir)/libcamera/\"\n }\n","prefixes":["libcamera-devel"]}