{"id":12707,"url":"https://patchwork.libcamera.org/api/1.1/patches/12707/?format=json","web_url":"https://patchwork.libcamera.org/patch/12707/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210625130848.28447-1-laurent.pinchart@ideasonboard.com>","date":"2021-06-25T13:08:48","name":"[libcamera-devel] android: mm: cros_camera_buffer: Drop undefined functions","commit_ref":"4510638e5daf470a173596ce3f33a9e3b236f842","pull_url":null,"state":"accepted","archived":false,"hash":"65f59d27c81f519187b5bfa5a5e5d6cc7c0e3dbc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12707/mbox/","series":[{"id":2175,"url":"https://patchwork.libcamera.org/api/1.1/series/2175/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2175","date":"2021-06-25T13:08:48","name":"[libcamera-devel] android: mm: cros_camera_buffer: Drop undefined functions","version":1,"mbox":"https://patchwork.libcamera.org/series/2175/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12707/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12707/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D535EC321D\n\tfor ;\n\tFri, 25 Jun 2021 13:09:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BEC8684CD;\n\tFri, 25 Jun 2021 15:09:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E50BD684C9\n\tfor ;\n\tFri, 25 Jun 2021 15:09:23 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A1E78B6\n\tfor ;\n\tFri, 25 Jun 2021 15:09:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bLX5EoaB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624626563;\n\tbh=iLEjv/5KeRHDXfB84KTzMGUiYyGhAJe+4znMb4rtFG4=;\n\th=From:To:Subject:Date:From;\n\tb=bLX5EoaBmg7rPQB0Zw0qU0mhaATVuSXCgwP9a5PdFZLZyRbc/C+uBrbzpYz8EIl3d\n\t1PlnCFt1vQyZd6I8Um6hOX+7SKvpo3NIsbQfBa7W1oSACKpp7VRE+5Ddd43J46Ytm+\n\t9EiKvTcEGQz5EuYpACH4VNEATWhSmgu5884bdr80=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 25 Jun 2021 16:08:48 +0300","Message-Id":"<20210625130848.28447-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Drop\n\tundefined functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraBuffer::Private::planeAddr() functions are declared but not\ndefined (and of course not used). Drop them.\n\nFixes: d8d6a78f223e (\"android: Introduce Chromium OS buffer manager\")\nSigned-off-by: Laurent Pinchart \n---\n src/android/mm/cros_camera_buffer.cpp | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\nindex c4157606d762..317d3e23687f 100644\n--- a/src/android/mm/cros_camera_buffer.cpp\n+++ b/src/android/mm/cros_camera_buffer.cpp\n@@ -42,9 +42,6 @@ private:\n \t\tvoid *addr;\n \t\tandroid_ycbcr ycbcr;\n \t} mem;\n-\n-\tconst uint8_t *planeAddr(unsigned int plane) const;\n-\tuint8_t *planeAddr(unsigned int plane);\n };\n \n CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n","prefixes":["libcamera-devel"]}