{"id":12700,"url":"https://patchwork.libcamera.org/api/1.1/patches/12700/?format=json","web_url":"https://patchwork.libcamera.org/patch/12700/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210624105054.51700-4-paul.elder@ideasonboard.com>","date":"2021-06-24T10:50:54","name":"[libcamera-devel,RFC,v2,3/3] android: Plumb AwbLock control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"df2cf6245e3b7b7b61c38407998c6e1d022dc714","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12700/mbox/","series":[{"id":2172,"url":"https://patchwork.libcamera.org/api/1.1/series/2172/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2172","date":"2021-06-24T10:50:51","name":"Static metadata helpers","version":2,"mbox":"https://patchwork.libcamera.org/series/2172/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12700/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12700/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B77DFC321C\n\tfor ;\n\tThu, 24 Jun 2021 10:51:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7815B68EA4;\n\tThu, 24 Jun 2021 12:51:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BC8968936\n\tfor ;\n\tThu, 24 Jun 2021 12:51:11 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E538B2C51;\n\tThu, 24 Jun 2021 12:51:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NV+SBRaV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624531871;\n\tbh=PQvVp+NzeQqrwNKqYJIbiU1nHFPvRx5gmj0ipim3fxQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NV+SBRaVskdFsZNOxwSCeU9ahSPt9/4Dy7/P6xAjFxwZQWvQRBz62wvhJKLYRh+NP\n\t6A0+tnGiVCmgxY/VUpa2nWvW+BqwZkFn1tPkEqIpgGpxIMkjP1gA4awle1Zw+J59zN\n\tx4/0Ge5kevCQbuMb8oicV9y/yh+KTTlqIgAYn9aY=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Jun 2021 19:50:54 +0900","Message-Id":"<20210624105054.51700-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210624105054.51700-1-paul.elder@ideasonboard.com>","References":"<20210624105054.51700-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v2 3/3] android: Plumb AwbLock control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Plumb the AwbLock control into the HAL for\nCONTROL_AWB_LOCK_AVAILABLE_MODES for static metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=45\nSigned-off-by: Paul Elder \n\n---\nChanges in v2:\n- use new setMetadata\n- rebase on camera capabilities refactor\n\nTODO: plumb result metadata\n---\n src/android/camera_capabilities.cpp | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 212d61d9..164006f2 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -602,9 +602,14 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_LOCK_AVAILABLE,\n \t\t\t\t aeLockAvailable);\n \n-\tuint8_t awbLockAvailable = ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE;\n-\tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n-\t\t\t\t awbLockAvailable);\n+\tuint8_t awbLockAvailable =\n+\t\tsetMetadata(staticMetadata_.get(), ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n+\t\t\t controlsInfo, &controls::AwbLock,\n+\t\t\t (uint8_t)ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE, Max);\n+\tif (!awbLockAvailable) {\n+\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE] = false;\n+\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING] = false;\n+\t}\n \n \tchar availableControlModes = ANDROID_CONTROL_MODE_AUTO;\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_MODES,\n","prefixes":["libcamera-devel","RFC","v2","3/3"]}