{"id":12699,"url":"https://patchwork.libcamera.org/api/1.1/patches/12699/?format=json","web_url":"https://patchwork.libcamera.org/patch/12699/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210624105054.51700-3-paul.elder@ideasonboard.com>","date":"2021-06-24T10:50:53","name":"[libcamera-devel,RFC,v2,2/3] android: Plumb AwbMode control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c043180175d9583f6012bc165c584c7193755078","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12699/mbox/","series":[{"id":2172,"url":"https://patchwork.libcamera.org/api/1.1/series/2172/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2172","date":"2021-06-24T10:50:51","name":"Static metadata helpers","version":2,"mbox":"https://patchwork.libcamera.org/series/2172/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12699/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12699/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D1ADC321A\n\tfor ;\n\tThu, 24 Jun 2021 10:51:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EE6A68EA1;\n\tThu, 24 Jun 2021 12:51:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E12D6893C\n\tfor ;\n\tThu, 24 Jun 2021 12:51:09 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB0822C51;\n\tThu, 24 Jun 2021 12:51:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OXlA0uie\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624531869;\n\tbh=7QYSs0V7onZo95wqhgLWnac4UNvDgbW9n5kMigWUo1c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OXlA0uie3rzyYc3kW0uZQ7pXA38jaCv8XE+tnfBR8JerL3wRlQ6/P+atOL7Nagj3Q\n\thPFWfKQ+qKbBfnQzX8G2aoSsMLwba9hhqe7JnfNnXu/vIQ1aez2vMh278zt0BngmF2\n\t7ArScMlDOCUzuQijV4E6SiH6N6FmZByZSJdN4xHE=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Jun 2021 19:50:53 +0900","Message-Id":"<20210624105054.51700-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210624105054.51700-1-paul.elder@ideasonboard.com>","References":"<20210624105054.51700-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v2 2/3] android: Plumb AwbMode control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Plumb the AwbMode control into the HAL for\nCONTROL_AWB_AVAILABLE_MODES for static metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=44\nSigned-off-by: Paul Elder \n\n---\nChanges in v2:\n- use new setMetadata\n- rebase on camera capabilities refactor\n\nTODO: plumb result metadata\n---\n src/android/camera_capabilities.cpp | 19 ++++++++++---------\n 1 file changed, 10 insertions(+), 9 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 7d795bf5..212d61d9 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -573,15 +573,16 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_VIDEO_STABILIZATION_MODES,\n \t\t\t\t availableStabilizationModes);\n \n-\t/*\n-\t * \\todo Inspect the camera capabilities to report the available\n-\t * AWB modes. Default to AUTO as CTS tests require it.\n-\t */\n-\tstd::vector availableAwbModes = {\n-\t\tANDROID_CONTROL_AWB_MODE_AUTO,\n-\t};\n-\tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n-\t\t\t\t availableAwbModes);\n+\tstd::vector awbModes =\n+\t\tsetMetadata(staticMetadata_.get(), ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n+\t\t\t controlsInfo, &controls::AwbMode,\n+\t\t\t std::vector({ ANDROID_CONTROL_AWB_MODE_AUTO }));\n+\tif (std::find(awbModes.begin(), awbModes.end(),\n+\t\t ANDROID_CONTROL_AWB_MODE_OFF) == awbModes.end()) {\n+\t\tfullSupport = false;\n+\t\t/* \\todo Double check if this is the correct capability */\n+\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING] = false;\n+\t}\n \n \tstd::vector availableMaxRegions = {\n \t\t0, 0, 0,\n","prefixes":["libcamera-devel","RFC","v2","2/3"]}