{"id":12608,"url":"https://patchwork.libcamera.org/api/1.1/patches/12608/?format=json","web_url":"https://patchwork.libcamera.org/patch/12608/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210616095610.3593281-1-kieran.bingham@ideasonboard.com>","date":"2021-06-16T09:56:10","name":"[libcamera-devel] libcamera: pipeline: vimc: Fail without an IPA","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4ed52311889c319c7a6e913ff073bb329e297e8b","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12608/mbox/","series":[{"id":2139,"url":"https://patchwork.libcamera.org/api/1.1/series/2139/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2139","date":"2021-06-16T09:56:10","name":"[libcamera-devel] libcamera: pipeline: vimc: Fail without an IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/2139/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12608/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12608/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BFA1C3218\n\tfor ;\n\tWed, 16 Jun 2021 09:56:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CAF468940;\n\tWed, 16 Jun 2021 11:56:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0D776050C\n\tfor ;\n\tWed, 16 Jun 2021 11:56:13 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 26766F88;\n\tWed, 16 Jun 2021 11:56:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lJzVB/FD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623837373;\n\tbh=7H3iK/ApdoWyRJ8O1Nuc4stYFx4S1ZLeFHHW7MogMY4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=lJzVB/FDTmkmQLXH/Own4H/Y5+6O43vFCgmEhUpbLNGHxUzPzxWY4f8Ei8c6blhVI\n\tVtDBnD772r7Tvi6U6jL1kO8ikq9BH3JhQONSxjs6Fm3IS58KyrIxHjuQ0NirtVIUe3\n\tnz1cCwGs0mZGIHbqWeVJKPROzDVsIPaVo0HzIWp0=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 16 Jun 2021 10:56:10 +0100","Message-Id":"<20210616095610.3593281-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: pipeline: vimc: Fail without\n\tan IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Registering a camera for VIMC without an IPA will fail later when\nattempting to configure.\n\nThe IPA is required for VIMC so fail early if it can't be loaded.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/pipeline/vimc/vimc.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 9ebd723be171..8af0e92012e6 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -431,6 +431,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \t\tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() });\n \t} else {\n \t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n+\t\treturn false;\n \t}\n \n \t/* Create and register the camera. */\n","prefixes":["libcamera-devel"]}