{"id":12582,"url":"https://patchwork.libcamera.org/api/1.1/patches/12582/?format=json","web_url":"https://patchwork.libcamera.org/patch/12582/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210614095340.3051816-3-naush@raspberrypi.com>","date":"2021-06-14T09:53:36","name":"[libcamera-devel,2/6] ipa: raspberrypi: Set default values for member variables of MdParser","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"61b3457cbd8f19b5566a8a575e88147e73793720","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12582/mbox/","series":[{"id":2128,"url":"https://patchwork.libcamera.org/api/1.1/series/2128/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2128","date":"2021-06-14T09:53:34","name":"Raspberry Pi: Metadata parsing improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/2128/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12582/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12582/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8FA8C3218\n\tfor ;\n\tMon, 14 Jun 2021 09:53:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D13D56892F;\n\tMon, 14 Jun 2021 11:53:51 +0200 (CEST)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C8A668933\n\tfor ;\n\tMon, 14 Jun 2021 11:53:47 +0200 (CEST)","by mail-wr1-x433.google.com with SMTP id c5so13820524wrq.9\n\tfor ;\n\tMon, 14 Jun 2021 02:53:47 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:fd93:d554:2dff:83ca])\n\tby smtp.gmail.com with ESMTPSA id\n\tc2sm19834891wmf.24.2021.06.14.02.53.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 14 Jun 2021 02:53:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ndbKxKRB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ifVD5IiwHvkcKKMT1rdm93U31ooE4K5nZEZrQlYCzcg=;\n\tb=ndbKxKRBg/iInp20v+RYGpJS8SPSoCqD1IZlbhgSgsDJxy7RFiELbbmB5mXqzuaoz0\n\tInpHKYfKjiGLG2v5qYX/E+VYpuOA8/z3x4MljcB4SN/RdTwBCkO8UijBku3iWwM47KvA\n\tJ4gqDe983s6njBhZwhnVf8CDgESZaElyU6W1hR/88fKiSCzmF4vER4LLEW+LO6LUm2P7\n\tN6hkuvrpspsa0AgLMXRJ9nJJrHyXEzr2sVUPNXcrBLqtPvMUph1sQTpb9raOnB3tcNl6\n\tKOgEBBpFAR/r9bc0nkp7PSAP775zGaiU2RS4ej7R6XtS/hAyJTFamZZaggYEmyeLuUyX\n\tf5vg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ifVD5IiwHvkcKKMT1rdm93U31ooE4K5nZEZrQlYCzcg=;\n\tb=ZN3gCPyUygdD6Uh8YaP8QiRUXOFBYpVsyfifaN+Kr7D90NsI9i6JrlP1kBL0jTcpvs\n\taYN8wFjtR4o6EEh/YT220MShB4JzJzVKgl0uCEDrhokiAoaD2wWKR80LLGC7oQUSWs2N\n\tMcF0eu3dPs3X1WOvzkY249LVa7z8c8mRhQhivzOjkfxkTCQUysYh5vMAH9sGV98goYR2\n\tOyICP+cTQpv46UKL5WidEFEc3aHmIgEH23/NgftPvVIvYmEYL3NRXous/QgD7USvHbdA\n\tV9puJ6Tg+A0J1giPdRDgdRgWnlP0QuapaCKLaeot9aZU7WxXFgmkiZyU3h5VwjfQeVYQ\n\truGw==","X-Gm-Message-State":"AOAM530hejHjI+wxHphTXJUfw5xbgh2OrZ2VI2cgBoxee30hMYRhZUEv\n\tZzNSlMVv49IWV9mpbsnsmbvnbmr00xTJbA==","X-Google-Smtp-Source":"ABdhPJxHrbEDsWHYr5x6LLoyz3t48/FJwrOQQI9L8rzo/7pEhvkdJCykCG2EMCsrUPdjH/ydFrjYkg==","X-Received":"by 2002:adf:e7d0:: with SMTP id\n\te16mr17372066wrn.202.1623664426749; \n\tMon, 14 Jun 2021 02:53:46 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 14 Jun 2021 10:53:36 +0100","Message-Id":"<20210614095340.3051816-3-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210614095340.3051816-1-naush@raspberrypi.com>","References":"<20210614095340.3051816-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/6] ipa: raspberrypi: Set default values\n\tfor member variables of MdParser","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Set some sensible default values for member variables of the MdParser class.\n\nRemove buffer_size_bytes_ along with some related asserts as this class now uses\nlibcamera::Span for buffer handling, and buffer_size_bytes_ is unused.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/raspberrypi/cam_helper_imx219.cpp | 1 -\n src/ipa/raspberrypi/cam_helper_imx477.cpp | 1 -\n src/ipa/raspberrypi/md_parser.hpp | 4 ++--\n 3 files changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/cam_helper_imx219.cpp b/src/ipa/raspberrypi/cam_helper_imx219.cpp\nindex e550fba62cde..ec218dce5456 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx219.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx219.cpp\n@@ -128,7 +128,6 @@ MdParser::Status MdParserImx219::Parse(libcamera::Span buffer)\n \t\t * registers.\n \t\t */\n \t\tassert(bits_per_pixel_);\n-\t\tassert(num_lines_ || buffer_size_bytes_);\n \t\t/* Need to be ordered */\n \t\tuint32_t regs[3] = { GAIN_REG, EXPHI_REG, EXPLO_REG };\n \t\treg_offsets_[0] = reg_offsets_[1] = reg_offsets_[2] = -1;\ndiff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp\nindex a4a58c15467d..25b36bce0dac 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n@@ -117,7 +117,6 @@ MdParser::Status MdParserImx477::Parse(libcamera::Span buffer)\n \t\t * registers.\n \t\t */\n \t\tassert(bits_per_pixel_);\n-\t\tassert(num_lines_ || buffer_size_bytes_);\n \t\t/* Need to be ordered */\n \t\tuint32_t regs[4] = {\n \t\t\tEXPHI_REG,\ndiff --git a/src/ipa/raspberrypi/md_parser.hpp b/src/ipa/raspberrypi/md_parser.hpp\nindex 86e0577614e0..25ba0e7c9400 100644\n--- a/src/ipa/raspberrypi/md_parser.hpp\n+++ b/src/ipa/raspberrypi/md_parser.hpp\n@@ -68,7 +68,8 @@ public:\n \t\tERROR = 2\n \t};\n \n-\tMdParser() : reset_(true)\n+\tMdParser()\n+\t\t: reset_(true), bits_per_pixel_(0), num_lines_(0), line_length_bytes_(0)\n \t{\n \t}\n \n@@ -103,7 +104,6 @@ protected:\n \tint bits_per_pixel_;\n \tunsigned int num_lines_;\n \tunsigned int line_length_bytes_;\n-\tunsigned int buffer_size_bytes_;\n };\n \n /*\n","prefixes":["libcamera-devel","2/6"]}