{"id":12511,"url":"https://patchwork.libcamera.org/api/1.1/patches/12511/?format=json","web_url":"https://patchwork.libcamera.org/patch/12511/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210608074225.59862-3-umang.jain@ideasonboard.com>","date":"2021-06-08T07:42:24","name":"[libcamera-devel,v2,2/3] ipa: ipu3: Copy IPACameraSensorInfo for future usage","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4ba59cfd9eee0c37c751629f5a5bee75c58bc60e","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12511/mbox/","series":[{"id":2109,"url":"https://patchwork.libcamera.org/api/1.1/series/2109/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2109","date":"2021-06-08T07:42:22","name":"IPAIPU3 drive-by improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/2109/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12511/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12511/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADCA7C3206\n\tfor ;\n\tTue, 8 Jun 2021 07:42:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BCF46892D;\n\tTue, 8 Jun 2021 09:42:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B9F768933\n\tfor ;\n\tTue, 8 Jun 2021 09:42:40 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.98])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2CECE71;\n\tTue, 8 Jun 2021 09:42:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LlHp+4BD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623138160;\n\tbh=2j2uy5e7NniPJvJTncUwfhFUESzu266LQlyFR+UkQFQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LlHp+4BD/bmz4z8KBz15RjkTS3FJ+pYybK0fZTBRSnirZVINdlU/Fx10gf4Mhxfy0\n\tzPQXiQLIjZ5/U/G7T65hqVx+zA46Vmatjvt0BnlZBwVCL+0ttZeaezqGWRhPBsonm3\n\tsFxGuRJfJaWtyeKhgRitOilzTVqd6owxAG9zbxxA=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 8 Jun 2021 13:12:24 +0530","Message-Id":"<20210608074225.59862-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210608074225.59862-1-umang.jain@ideasonboard.com>","References":"<20210608074225.59862-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/3] ipa: ipu3: Copy\n\tIPACameraSensorInfo for future usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"IPACameraSensorInfo members will be needed at various places in the\nIPAIPU3 class, in subsequent commits. Hence, it seems trivial to copy\nthis structure for wider availability throughout the class.\n\nThis commit does not introduce any functional changes.\n\nSigned-off-by: Umang Jain \nTested-by: Paul Elder \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/ipu3.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 2496b0a0..97ddb863 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -63,6 +63,8 @@ private:\n \n \tControlInfoMap ctrls_;\n \n+\tIPACameraSensorInfo sensorInfo_;\n+\n \t/* Camera sensor controls. */\n \tuint32_t exposure_;\n \tuint32_t minExposure_;\n@@ -144,6 +146,8 @@ void IPAIPU3::configure(const IPAConfigInfo &configInfo)\n \tif (configInfo.entityControls.empty())\n \t\treturn;\n \n+\tsensorInfo_ = configInfo.sensorInfo;\n+\n \tctrls_ = configInfo.entityControls.at(0);\n \n \tconst auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);\n@@ -174,7 +178,7 @@ void IPAIPU3::configure(const IPAConfigInfo &configInfo)\n \tawbAlgo_->initialise(params_, configInfo.bdsOutputSize, bdsGrid_);\n \n \tagcAlgo_ = std::make_unique();\n-\tagcAlgo_->initialise(bdsGrid_, configInfo.sensorInfo);\n+\tagcAlgo_->initialise(bdsGrid_, sensorInfo_);\n }\n \n void IPAIPU3::mapBuffers(const std::vector &buffers)\n","prefixes":["libcamera-devel","v2","2/3"]}