{"id":12508,"url":"https://patchwork.libcamera.org/api/1.1/patches/12508/?format=json","web_url":"https://patchwork.libcamera.org/patch/12508/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210607181506.51711-6-nfraprado@collabora.com>","date":"2021-06-07T18:15:06","name":"[libcamera-devel,v6,5/5] lc-compliance: Add list and filter parameters","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d4d92eeb8c808e680c3f3758e0f2f4f7364c44e4","submitter":{"id":84,"url":"https://patchwork.libcamera.org/api/1.1/people/84/?format=json","name":"Nícolas F. R. A. Prado","email":"nfraprado@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12508/mbox/","series":[{"id":2108,"url":"https://patchwork.libcamera.org/api/1.1/series/2108/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2108","date":"2021-06-07T18:15:01","name":"lc-compliance: Refactor using Googletest","version":6,"mbox":"https://patchwork.libcamera.org/series/2108/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12508/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12508/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14EC9C320B\n\tfor ;\n\tMon, 7 Jun 2021 18:16:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBEBE68930;\n\tMon, 7 Jun 2021 20:16:17 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14015602A7\n\tfor ;\n\tMon, 7 Jun 2021 20:16:17 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2804:14c:1a9:2978:d3df:ab8:a31a:aacc])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 5E92A1F422E2;\n\tMon, 7 Jun 2021 19:16:14 +0100 (BST)"],"From":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 7 Jun 2021 15:15:06 -0300","Message-Id":"<20210607181506.51711-6-nfraprado@collabora.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210607181506.51711-1-nfraprado@collabora.com>","References":"<20210607181506.51711-1-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 5/5] lc-compliance: Add list and filter\n\tparameters","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel@collabora.com, =?utf-8?q?Andr=C3=A9_Almeida?=\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a --list parameter that lists all current tests (by mapping to\ngoogletest's --gtest_list_tests).\n\nAdd a --filter 'filterString' parameter that filters the tests to run\n(by mapping to googletest's --gtest_filter).\n\nSigned-off-by: Nícolas F. R. A. Prado \n---\nChanges in v6:\n- Thanks to Niklas:\n - Changed buildGtestParameters() into initGtestParameters() and removed the\n need for Harness::gtestArgc_ and Harness::gtestArgv_\n\nChanges in v5:\n- Thanks to Niklas:\n - Moved buildGtestParameters() inside run()\n\nNo changes in v4\n\n src/lc-compliance/main.cpp | 69 +++++++++++++++++++++++++++++++++++---\n 1 file changed, 65 insertions(+), 4 deletions(-)","diff":"diff --git a/src/lc-compliance/main.cpp b/src/lc-compliance/main.cpp\nindex 27503372d0eb..e35238471ee6 100644\n--- a/src/lc-compliance/main.cpp\n+++ b/src/lc-compliance/main.cpp\n@@ -20,6 +20,8 @@ using namespace libcamera;\n \n enum {\n \tOptCamera = 'c',\n+\tOptList = 'l',\n+\tOptFilter = 'f',\n \tOptHelp = 'h',\n };\n \n@@ -45,13 +47,17 @@ public:\n \t~Harness();\n \n \tint init();\n-\tint run(int argc, char **argv);\n+\tint run(char *arg0);\n \n private:\n+\tint initGtestParameters(char *arg0);\n \tvoid listCameras();\n \n \tOptionsParser::Options options_;\n \tstd::shared_ptr cm_;\n+\n+\tconst std::map gtestFlag_ = { { \"list\", \"--gtest_list_tests\" },\n+\t\t\t\t\t\t\t\t{ \"filter\", \"--gtest_filter\" } };\n };\n \n Harness::Harness(const OptionsParser::Options &options)\n@@ -76,6 +82,12 @@ int Harness::init()\n \t\treturn ret;\n \t}\n \n+\t/*\n+\t * No need to initialize the camera if we'll just list tests\n+\t */\n+\tif (options_.isSet(OptList))\n+\t\treturn 0;\n+\n \tif (!options_.isSet(OptCamera)) {\n \t\tstd::cout << \"No camera specified, available cameras:\" << std::endl;\n \t\tlistCameras();\n@@ -97,9 +109,11 @@ int Harness::init()\n \treturn 0;\n }\n \n-int Harness::run(int argc, char **argv)\n+int Harness::run(char *arg0)\n {\n-\t::testing::InitGoogleTest(&argc, argv);\n+\tint ret = initGtestParameters(arg0);\n+\tif (ret)\n+\t\treturn ret;\n \n \ttesting::UnitTest::GetInstance()->listeners().Append(new ThrowListener);\n \n@@ -112,12 +126,59 @@ void Harness::listCameras()\n \t\tstd::cout << \"- \" << cam.get()->id() << std::endl;\n }\n \n+int Harness::initGtestParameters(char *arg0)\n+{\n+\tint argc = 0;\n+\tchar **argv;\n+\tstd::string filterParam;\n+\n+\t/*\n+\t * +2 to have space for both the 0th argument that is needed but not\n+\t * used and the null at the end.\n+\t */\n+\targv = (char **) malloc((gtestFlag_.size() + 2) * sizeof(char *));\n+\tif (!argv)\n+\t\treturn -ENOMEM;\n+\n+\targv[argc] = arg0;\n+\targc++;\n+\n+\tif (options_.isSet(OptList)) {\n+\t\targv[argc] = const_cast(gtestFlag_.at(\"list\").c_str());\n+\t\targc++;\n+\t}\n+\n+\tif (options_.isSet(OptFilter)) {\n+\t\t/*\n+\t\t * The filter flag needs to be passed as a single parameter, in\n+\t\t * the format --gtest_filter=filterStr\n+\t\t */\n+\t\tconst std::string &filter = options_[OptFilter];\n+\t\tfilterParam = gtestFlag_.at(\"filter\") + \"=\" + filter;\n+\n+\t\targv[argc] = const_cast(filterParam.c_str());\n+\t\targc++;\n+\t}\n+\n+\targv[argc] = 0;\n+\n+\t::testing::InitGoogleTest(&argc, argv);\n+\n+\tfree(argv);\n+\n+\treturn 0;\n+}\n+\n static int parseOptions(int argc, char **argv, OptionsParser::Options *options)\n {\n \tOptionsParser parser;\n \tparser.addOption(OptCamera, OptionString,\n \t\t\t \"Specify which camera to operate on, by id\", \"camera\",\n \t\t\t ArgumentRequired, \"camera\");\n+\tparser.addOption(OptList, OptionNone, \"List all tests and exit\", \"list\");\n+\tparser.addOption(OptFilter, OptionString,\n+\t\t\t \"Specify which tests to run\", \"filter\",\n+\t\t\t ArgumentRequired, \"filter\");\n \tparser.addOption(OptHelp, OptionNone, \"Display this help message\",\n \t\t\t \"help\");\n \n@@ -147,5 +208,5 @@ int main(int argc, char **argv)\n \tif (ret)\n \t\treturn ret;\n \n-\treturn harness.run(argc, argv);\n+\treturn harness.run(argv[0]);\n }\n","prefixes":["libcamera-devel","v6","5/5"]}