{"id":12415,"url":"https://patchwork.libcamera.org/api/1.1/patches/12415/?format=json","web_url":"https://patchwork.libcamera.org/patch/12415/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210526000855.17501-2-laurent.pinchart@ideasonboard.com>","date":"2021-05-26T00:08:54","name":"[libcamera-devel,1/2] android: camera_hal_config: Move include to .cpp file","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"12ef68654aeedbd730b50d06074498367bdb3ca9","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12415/mbox/","series":[{"id":2067,"url":"https://patchwork.libcamera.org/api/1.1/series/2067/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2067","date":"2021-05-26T00:08:53","name":"Fix Android camera HAL compilation on gcc 7 and 8","version":1,"mbox":"https://patchwork.libcamera.org/series/2067/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12415/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12415/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CD7FC3200\n\tfor ;\n\tWed, 26 May 2021 00:09:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAC3868918;\n\tWed, 26 May 2021 02:09:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C53668918\n\tfor ;\n\tWed, 26 May 2021 02:09:05 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D2699580\n\tfor ;\n\tWed, 26 May 2021 02:09:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SjIs6mRh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621987745;\n\tbh=2OYjdNlqU9Qp7zHGYe3BceKU2NNpvU72Yd/bziagMls=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=SjIs6mRhsl3wDKm+QjZM3Ae/vb11s9lhndKud7PenT8bLTheDCO0XCLNF5s8otgaK\n\tNBoZZ7/aTkNf1gN1tg82/okQ/DD7nj/9ItEMxTPD2zuQEoM3SdDtrbGXRGK+m36aYW\n\t2ieYeAQs/8fhnuBEGIJjwZEAQdVcmUxm0FT24HFc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 26 May 2021 03:08:54 +0300","Message-Id":"<20210526000855.17501-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.1","In-Reply-To":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>","References":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] android: camera_hal_config: Move\n\tinclude to .cpp file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The header isn't needed in camera_hal_config.h, move its\ninclusion to camera_hal_config.cpp.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_hal_config.cpp | 1 +\n src/android/camera_hal_config.h | 1 -\n 2 files changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\nindex 12d69a3f5f3c..d15df2e30c2c 100644\n--- a/src/android/camera_hal_config.cpp\n+++ b/src/android/camera_hal_config.cpp\n@@ -6,6 +6,7 @@\n */\n #include \"camera_hal_config.h\"\n \n+#include \n #include \n #include \n #include \ndiff --git a/src/android/camera_hal_config.h b/src/android/camera_hal_config.h\nindex 0555c6da2c20..97dc69c1def5 100644\n--- a/src/android/camera_hal_config.h\n+++ b/src/android/camera_hal_config.h\n@@ -7,7 +7,6 @@\n #ifndef __ANDROID_CAMERA_HAL_CONFIG_H__\n #define __ANDROID_CAMERA_HAL_CONFIG_H__\n \n-#include \n #include \n #include \n \n","prefixes":["libcamera-devel","1/2"]}