{"id":124,"url":"https://patchwork.libcamera.org/api/1.1/patches/124/?format=json","web_url":"https://patchwork.libcamera.org/patch/124/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190101212947.28098-4-kieran.bingham@ideasonboard.com>","date":"2019-01-01T21:29:45","name":"[libcamera-devel,3/5] test: Move include definitions to libtest","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8ea708270c894e3377f3a06669eeff73de7726b3","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/124/mbox/","series":[{"id":46,"url":"https://patchwork.libcamera.org/api/1.1/series/46/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=46","date":"2019-01-01T21:29:42","name":"test: Unit Test Improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/46/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/124/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/124/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B54E460B31\n\tfor ;\n\tTue, 1 Jan 2019 22:29:52 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 54382505;\n\tTue, 1 Jan 2019 22:29:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546378192;\n\tbh=TEJnxjI8ghCX294IOFqKWhhqxiq5mEL4rwgkVBVgbhk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QngcpfRgL0wRxVhNbte2BnT0+uBmjoVZGUOtNSqWQfwMQx+Y+RWWIebj8khxjozOe\n\tCPPoNc9SoEUWjP4hnryHy3AY2/sQ75ZruY1x/wI3nz4lk2lOShrt5zZXIxfIznZIHF\n\tkeg1vCwCETJQrumvXr+r2hwmG/Hp3+Xu/+4SJhDQ=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Tue, 1 Jan 2019 21:29:45 +0000","Message-Id":"<20190101212947.28098-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20190101212947.28098-1-kieran.bingham@ideasonboard.com>","References":"<20190101212947.28098-1-kieran.bingham@ideasonboard.com>","Subject":"[libcamera-devel] [PATCH 3/5] test: Move include definitions to\n\tlibtest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 01 Jan 2019 21:29:53 -0000"},"content":"With the libtest functionality moved to it's own library folder, the\ndefinitions for test inlcludes should reasonably live there too.\n\nThe libtest subdir should always remain the first entry in the\ntest/meson.build file.\n\nSigned-off-by: Kieran Bingham \n---\n test/libtest/meson.build | 12 ++++++++++++\n test/meson.build | 12 ------------\n 2 files changed, 12 insertions(+), 12 deletions(-)","diff":"diff --git a/test/libtest/meson.build b/test/libtest/meson.build\nindex b998154dd8d3..e0893b70c3d4 100644\n--- a/test/libtest/meson.build\n+++ b/test/libtest/meson.build\n@@ -5,3 +5,15 @@ libtest_sources = files([\n libtest = static_library('libtest', libtest_sources)\n \n libtest_includes = include_directories('.')\n+\n+test_libraries = [libcamera, libtest]\n+\n+test_includes_public = [\n+ libtest_includes,\n+ libcamera_includes,\n+]\n+\n+test_includes_internal = [\n+ test_includes_public,\n+ libcamera_internal_includes,\n+]\ndiff --git a/test/meson.build b/test/meson.build\nindex bf8232f32787..9270a55e052a 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -1,17 +1,5 @@\n subdir('libtest')\n \n-test_libraries = [libcamera, libtest]\n-\n-test_includes_public = [\n- libtest_includes,\n- libcamera_includes,\n-]\n-\n-test_includes_internal = [\n- test_includes_public,\n- libcamera_internal_includes,\n-]\n-\n subdir('media_device')\n \n public_tests = [\n","prefixes":["libcamera-devel","3/5"]}