{"id":12320,"url":"https://patchwork.libcamera.org/api/1.1/patches/12320/?format=json","web_url":"https://patchwork.libcamera.org/patch/12320/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210519075941.1337388-6-hiroh@chromium.org>","date":"2021-05-19T07:59:41","name":"[libcamera-devel,v5,6/6] android: CameraDevice: Report queried test pattern modes","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8cbcedef4a6c29a374fce1f3b3f62d4b20e17341","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12320/mbox/","series":[{"id":2037,"url":"https://patchwork.libcamera.org/api/1.1/series/2037/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2037","date":"2021-05-19T07:59:36","name":"[libcamera-devel,v5,1/6] libcamera: controls: Add sensor test pattern mode","version":5,"mbox":"https://patchwork.libcamera.org/series/2037/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12320/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12320/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AA60C3200\n\tfor ;\n\tWed, 19 May 2021 08:00:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAC6368926;\n\tWed, 19 May 2021 10:00:00 +0200 (CEST)","from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com\n\t[IPv6:2607:f8b0:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 814356891C\n\tfor ;\n\tWed, 19 May 2021 09:59:57 +0200 (CEST)","by mail-pf1-x42e.google.com with SMTP id e19so9344538pfv.3\n\tfor ;\n\tWed, 19 May 2021 00:59:57 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:3948:91a2:b8ec:1976])\n\tby smtp.gmail.com with ESMTPSA id\n\t80sm1160847pfw.200.2021.05.19.00.59.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 19 May 2021 00:59:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"m3L/ZrIf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=QZsnwxA2ke1bJ5i7sxS/mzf7jGdB3f5iGqyBHXj/sFc=;\n\tb=m3L/ZrIf10uDbuSYPJbsz9qfnKUKx/MNcfJRpgeHymaKVCi1odrvjMBXogdIgO5XCf\n\tYPIshZzduFcS/jU56xhbPw6lgu2neWe5KyxXlRNbILaKUCrXWHwS4F3DbvmyAP7qkcDr\n\t67laSNq566sykHjNHXDP4TdkbaQx3uzJGqB6Y=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QZsnwxA2ke1bJ5i7sxS/mzf7jGdB3f5iGqyBHXj/sFc=;\n\tb=e/xfn+l4VDy5HpMZTSzz0ixTxysqFo0g9HBYWy56tDXjHX7Nds8D07/IgdrfXpfppB\n\tneB0PyN9OV6aVFCgVN7blp97DGyqWdtRCiJcilc82DYQzBE/x6+zzovs+W+kHTA5Y194\n\tPp78des/C0Mz8bMWDDYrBlKIyYtMcF2BwXD17VFD2f52vB7V9Z3CUCVMfrnRP6kbNtx4\n\t5s0NIpfQ4kf1qIOYAmEnsfR9K1hBmHOLsrUKWWtsvLUL4ApmfuL0zbE/7r1lasU1Bdre\n\tjaV4dcFiaQqXuobDyq8VoBoSs3usaZPapy4UgGNNhCnzHYV+r6PBKT5GbUtp+XNUN08x\n\tmupQ==","X-Gm-Message-State":"AOAM533duqghcAPknVS2uRHLL9eCpDm+EQIPPupwVvD8BUuHO4BcIHdy\n\tHH4V3DT9dqjVwFFJhJzGo6C0ptTYL1tH6w==","X-Google-Smtp-Source":"ABdhPJyxj5KP4tTuV9CNxtdRjRzWQHdYB6OQQpLeYwHMP2X4zuwVZ/cTBRg3MF2CaJ699y2Mn9jTUg==","X-Received":"by 2002:a63:e952:: with SMTP id\n\tq18mr9579721pgj.430.1621411195873; \n\tWed, 19 May 2021 00:59:55 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 19 May 2021 16:59:41 +0900","Message-Id":"<20210519075941.1337388-6-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.1.751.gd2f1c929bd-goog","In-Reply-To":"<20210519075941.1337388-1-hiroh@chromium.org>","References":"<20210519075941.1337388-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 6/6] android: CameraDevice: Report\n\tqueried test pattern modes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report to the Android camera stack the list of supported test\npattern modes constructed by inspecting the values reported\nby libcamera through the controls::draft::TestPatternMode control.\n\nSigned-off-by: Hirokazu Honda \n---\n src/android/camera_device.cpp | 47 ++++++++++++++++++++++++++++++++---\n 1 file changed, 44 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex b32e8be5..a07679a3 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1035,11 +1035,52 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \n \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, orientation_);\n \n-\tstd::vector testPatterModes = {\n-\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF,\n+\tstd::vector testPatternModes = {\n+\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF\n \t};\n+\tif (const auto &testPatternsInfo =\n+\t\t controlsInfo.find(&controls::draft::TestPatternMode);\n+\t testPatternsInfo != controlsInfo.end()) {\n+\t\tconst auto &values = testPatternsInfo->second.values();\n+\t\tASSERT(!values.empty());\n+\t\tfor (const auto &value : values) {\n+\t\t\tswitch (value.get()) {\n+\t\t\tcase controls::draft::TestPatternModeOff:\n+\t\t\t\t/*\n+\t\t\t\t * ANDROID_SENSOR_TEST_PATTERN_MODE_OFF is\n+\t\t\t\t * already in testPatternModes.\n+\t\t\t\t */\n+\t\t\t\tbreak;\n+\t\t\tcase controls::draft::TestPatternModeSolidColor:\n+\t\t\t\ttestPatternModes.push_back(\n+\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_SOLID_COLOR);\n+\t\t\t\tbreak;\n+\t\t\tcase controls::draft::TestPatternModeColorBars:\n+\t\t\t\ttestPatternModes.push_back(\n+\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_COLOR_BARS);\n+\t\t\t\tbreak;\n+\t\t\tcase controls::draft::TestPatternModeColorBarsFadeToGray:\n+\t\t\t\ttestPatternModes.push_back(\n+\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_COLOR_BARS_FADE_TO_GRAY);\n+\t\t\t\tbreak;\n+\t\t\tcase controls::draft::TestPatternModePn9:\n+\t\t\t\ttestPatternModes.push_back(\n+\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_PN9);\n+\t\t\t\tbreak;\n+\t\t\tcase controls::draft::TestPatternModeCustom1:\n+\t\t\t\ttestPatternModes.push_back(\n+\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_CUSTOM1);\n+\t\t\t\tbreak;\n+\t\t\tdefault:\n+\t\t\t\tLOG(HAL, Error)\n+\t\t\t\t\t<< \"Unknown test pattern mode: \"\n+\t\t\t\t\t<< value.get();\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\t\t}\n+\t}\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n-\t\t\t\t testPatterModes);\n+\t\t\t\t testPatternModes);\n \n \tuint8_t timestampSource = ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE_UNKNOWN;\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n","prefixes":["libcamera-devel","v5","6/6"]}